Merged
Conversation
Piinks
reviewed
Dec 2, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
one thing we could try is to run the analyze.sh script in a different test registry entry
This is a great idea. Can we do this?
Contributor
|
Devtools tests immediately failed after being re-enabled here. Reverting to fix the flutter/flutter build. |
Piinks
added a commit
that referenced
this pull request
Dec 2, 2024
Member
Author
Do you have a link to the failure? |
kenzieschmoll
added a commit
that referenced
this pull request
Dec 3, 2024
victoreronmosele
pushed a commit
to victoreronmosele/tests
that referenced
this pull request
Feb 5, 2025
Reverts flutter#431 to re-land flutter#430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables DevTools tests after the changes were made in flutter/devtools#8552 to reduce the number of tests running on each flutter commit.
Timing breakdown:
flutter packages get&&dart fix --apply- standard for all flutter customer tests)dart analyzeover DevTools code - also standard practice for flutter customer tests)If this is still too long, one thing we could try is to run the
analyze.shscript in a different test registry entry. The shard containing the DevTools test (linux shard 1) is still faster than linux shard 2, so reducing the time further may not be necessary since it will not improve the overall speed of the flutter customer test.EDIT: the analysis of the DevTools codebase was moved into its own registry entry to speed up performance.