Bump Zulip pin to update some tests that hard-code route animation duration#460
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Jun 11, 2025
Conversation
justinmc
approved these changes
Jun 5, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thank you for the quick fix here!
Contributor
|
@Piinks I think I also need a special review from someone like you? |
Contributor
|
Interesting, I needed to enable the workflow. I will check in with the infra team on that. Good to go! |
Contributor
|
autosubmit label was removed for flutter/tests/460, because - The status or check suite linux_tests (shard 1 of 3, 0) has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
It looks like the failure is actually in superlist's tests? Here's one file it's referring to: https://github.com/superlistapp/super_sliver_list/blob/main/example/lib/shell/app.dart How do we typically deal with that? |
Contributor
|
Hmm, this is strange. I just saw another PR move along ok recently. Let me rebase this just in case. |
…ration This updates to the following change in Zulip: zulip/zulip-flutter@834834b zulip/zulip-flutter#1547 in order to unblock this PR: flutter/flutter#165832
Piinks
force-pushed
the
pr-zulip-route-animation-durations
branch
from
78415f2 to
47060fc
Compare
9 tasks
chrisbobbe
added a commit
to chrisbobbe/flutter
that referenced
this pull request
Jun 18, 2025
This pulls in the 3 commits below: flutter/tests@7f55026...9a7ff44 2025-06-11 [email protected] Bump Zulip pin to update some tests that hard-code route animation duration (flutter/tests#460) 2025-06-10 [email protected] Bump patrol tests to b8bcebf96ff13e37fdc5474804d68e2352e472a4 (flutter/tests#451) 2025-06-02 [email protected] Re-enable DevTools tests (flutter/tests#459) (using the command from 5ce5251 / flutter#162763 to make the log). The latest change just went into flutter/tests yesterday and is why I'm making this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to the following change in Zulip:
zulip/zulip-flutter@834834b
zulip/zulip-flutter#1547
in order to unblock this PR:
flutter/flutter#165832
Important
This repository is a testing suite that contains references to tests (in the
registrydirectory) that are run with every commit to Flutterto verify that no breaking changes have been introduced (in the "customer_testing" shards). Your merged PR is not automatically run in the
Flutter CI tree.
After merging this PR, you must send another PR to flutter/flutter updating
dev/customer_testing/tests.versionin that repo with the latest git commit SHA of the flutter/test repo.See flutter/flutter#162048 for details.