Add test for package assorted_layout_widgets#64
Merged
dnfield merged 1 commit intoflutter:masterfrom Nov 12, 2020
passsy:feature/assorted_layout_widgets
Merged
Add test for package assorted_layout_widgets#64dnfield merged 1 commit intoflutter:masterfrom passsy:feature/assorted_layout_widgets
dnfield merged 1 commit intoflutter:masterfrom
passsy:feature/assorted_layout_widgets
Conversation
marcglasberg
approved these changes
Nov 12, 2020
marcglasberg
approved these changes
Nov 12, 2020
marcglasberg
previously approved these changes
Nov 12, 2020
dnfield
reviewed
Nov 12, 2020
| fetch=git clone https://github.com/marcglasberg/assorted_layout_widgets.git tests | ||
| fetch=git -C tests checkout 388db9ea38df1e0991ffdbe8e790699fb089202a | ||
| update=. | ||
| test=flutter test No newline at end of file |
Contributor
There was a problem hiding this comment.
@marcglasberg or @passsy - would this actually have failed at times where things broke? Looking at tests in this repo, I don't see any that actually exercise widget logic.
Maybe there would have been compilation errors, but it's not clear to me.
Contributor
Author
There was a problem hiding this comment.
Both would have been compilation errors
dnfield
reviewed
Nov 12, 2020
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM as long as tests pass
dnfield
approved these changes
Nov 12, 2020
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assorted_layout_widgetspackage had already to deal with breaking changes in the past.//cc @marcglasberg