This repository was archived by the owner on Nov 29, 2023. It is now read-only.
Change the webdriver package to run with install-only flag.#4
Merged
nturgut merged 2 commits intoflutter:masterfrom Feb 26, 2020
Merged
Change the webdriver package to run with install-only flag.#4nturgut merged 2 commits intoflutter:masterfrom
nturgut merged 2 commits intoflutter:masterfrom
Conversation
… without running it
13 tasks
ditman
approved these changes
Feb 26, 2020
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
The possible ways of running the webdrivers:
dart lib/web_driver_installer.dart & (used in flutter/flutter. uses chromedrivers command. installs and runs the driver)
dart lib/web_driver_installer.dart chromedriver (not it use. installs and runs the chrome driver)
dart lib/web_driver_installer.dart chromedriver install-only
That sounds like fantastic documentation for the README.md file :P
Contributor
Author
Done! Thanks for the suggestion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add flag install-only to install the driver without running it. Also add driver for chrome 78.
The possible ways of running the webdrivers:
dart lib/web_driver_installer.dart & (used in flutter/flutter. uses chromedrivers command. installs and runs the driver)
dart lib/web_driver_installer.dart chromedriver (not it use. installs and runs the chrome driver)
dart lib/web_driver_installer.dart chromedriver install-only (will be used in e2e package PR )