Update wasm page for beta and new docs by MaryaBelanger · Pull Request #10249 · flutter/website

MaryaBelanger · 2024-03-06T23:15:36Z

Fixes #10159 --- staged page

Updated the page to:

Point to new package:web and JS interop docs
Point to the beta channel instead of master
- ref: [flutter_tools] enable wasm compile on beta channel flutter#143779

Things that are NOT in this update (correct me if I'm wrong?):

Dual compile
- ref: Wasm/JS Dual Compile with the flutter tool flutter#141396
- Thought about adding a "Coming soon" section at the end of the page, (or as a subsection to the Serve section) describing what the feature will look like at a conceptual level -- thoughts?
- Will need to update the Run and Serve sections once the --wasm output goes to build/web not build/web_wasm
is:wasm-ready tag on pub.dev
- ref: Add badges for Wasm and SwiftUI compatibility dart-lang/pub-dev#6785
- Was thinking about referencing this is the "pick a flutter package" section, but the feature is not sound yet

flutter-website-bot · 2024-03-06T23:23:16Z

Visit the preview URL for this PR (updated for commit 13d17d3):

https://flutter-docs-prod--pr10249-wasm-update-1wumv5nf.web.app

src/platform-integration/web/wasm.md

MaryaBelanger · 2024-03-07T18:15:22Z

@kevmoo I set "last updated" to today (March 7), but I switched to the beta channel and followed the steps the page describes in this section and didn't see the "Experimental options" section at the end of the flutter build web --help output like it says I should.

So I'm guessing today is not actually the day; should I change "Last updated" to tomorrow?

kevmoo · 2024-03-07T22:11:39Z

@MaryaBelanger – as of RIGHT NOW beta has not landed. Hoping it's soon.

src/platform-integration/web/wasm.md

kevmoo

one thing to delete. then we need to deal with the {{}} bits

src/platform-integration/web/wasm.md

kevmoo

One nit then awesome!

Co-authored-by: Kevin Moore <[email protected]>

src/platform-integration/web/wasm.md

Co-authored-by: Kevin Moore <[email protected]>

domesticmouse · 2024-03-10T10:02:46Z

src/platform-integration/web/wasm.md

  Current status of Flutter's experimental support for WebAssembly (Wasm).
 short-title: Wasm
-last-update: November 21, 2023
+last-update: March 8, 2024


Just tagging this line as requires update.

parlough

Thanks for updating this @MaryaBelanger!

A few suggestions to consider:

src/platform-integration/web/wasm.md

Co-authored-by: Parker Lougheed <[email protected]>

sfshaza2

A few tweaks.

src/platform-integration/web/wasm.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

kevmoo · 2024-03-13T10:30:19Z

can we land this...like...now? 😄

Fixes flutter#10159 --------- Co-authored-by: Kevin Moore <[email protected]> Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

update wasm page for beta and new docs

62a8415

MaryaBelanger and others added 2 commits March 6, 2024 15:31

minor fixes

a77897d

Merge branch 'main' into wasm-update

cce0f59

MaryaBelanger marked this pull request as ready for review March 6, 2024 23:36

MaryaBelanger requested review from atsansone, domesticmouse, parlough and sfshaza2 as code owners March 6, 2024 23:36

MaryaBelanger requested a review from kevmoo March 6, 2024 23:36

MaryaBelanger added the review.tech Awaiting Technical Review label Mar 6, 2024

kevmoo reviewed Mar 6, 2024

View reviewed changes

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

domesticmouse approved these changes Mar 7, 2024

View reviewed changes

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

MaryaBelanger self-assigned this Mar 7, 2024

reviews and link

7bc27f9

MaryaBelanger mentioned this pull request Mar 7, 2024

Add before-and-after context to JS interop overview page dart-lang/site-www#5630

Closed

kevmoo feedback

8104726

MaryaBelanger requested a review from kevmoo March 8, 2024 15:55

johnpryan reviewed Mar 8, 2024

View reviewed changes

src/platform-integration/web/wasm.md Show resolved Hide resolved

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

src/platform-integration/web/wasm.md Show resolved Hide resolved

kevmoo reviewed Mar 8, 2024

View reviewed changes

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

kevmoo reviewed Mar 8, 2024

View reviewed changes

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

kevmoo reviewed Mar 8, 2024

View reviewed changes

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

kevmoo requested changes Mar 8, 2024

View reviewed changes

MaryaBelanger and others added 3 commits March 8, 2024 14:44

reviews

f9cb696

fix wording

8929a4f

Merge branch 'main' into wasm-update

4ea65c4

kevmoo reviewed Mar 8, 2024

View reviewed changes

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

kevmoo approved these changes Mar 8, 2024

View reviewed changes

kevmoo review

c12e265

Co-authored-by: Kevin Moore <[email protected]>

kevmoo reviewed Mar 8, 2024

View reviewed changes

src/platform-integration/web/wasm.md Outdated Show resolved Hide resolved

Update src/platform-integration/web/wasm.md

1a9f759

Co-authored-by: Kevin Moore <[email protected]>

kevmoo approved these changes Mar 9, 2024

View reviewed changes

domesticmouse approved these changes Mar 10, 2024

View reviewed changes

parlough approved these changes Mar 11, 2024

View reviewed changes

MaryaBelanger and others added 2 commits March 11, 2024 15:10

minor fixes

eaf83a9

parlough code review

17a73e3

Co-authored-by: Parker Lougheed <[email protected]>

sfshaza2 reviewed Mar 12, 2024

View reviewed changes

MaryaBelanger and others added 3 commits March 12, 2024 10:23

sfshaza2 review

ef72fae

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

date and link to updated js overview

2c4dddd

one more master > main

511751f

sfshaza2 added the review.await-update Awaiting Updates after Edits label Mar 12, 2024

last updated

13d17d3

MaryaBelanger mentioned this pull request Mar 13, 2024

Update wasm getting started instructions #10279

Merged

3 tasks

MaryaBelanger merged commit 40e0d1c into main Mar 13, 2024

MaryaBelanger deleted the wasm-update branch March 13, 2024 15:32

sfshaza2 removed review.tech Awaiting Technical Review review.await-update Awaiting Updates after Edits labels Mar 14, 2024

Conversation

MaryaBelanger commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-website-bot commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaryaBelanger commented Mar 7, 2024

Uh oh!

kevmoo commented Mar 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

domesticmouse Mar 10, 2024

Choose a reason for hiding this comment

Uh oh!

parlough left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sfshaza2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevmoo commented Mar 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MaryaBelanger commented Mar 6, 2024 •

edited

Loading

flutter-website-bot commented Mar 6, 2024 •

edited

Loading