Update wasm getting started instructions#10279
Merged
Conversation
mit-mit
requested review from
MaryaBelanger,
atsansone,
domesticmouse,
parlough and
sfshaza2
as code owners
Contributor
Collaborator
|
Visit the preview URL for this PR (updated for commit d151dd6): https://flutter-docs-prod--pr10279-mit-mit-patch-1-7sx2xwsb.web.app |
Member
Author
|
Yeah, somewhat duplicative it seems! We can't recommend beta just yet, as the build change (see my link above) just landed last night. In either case I'd love it if either of the PRs can be landed today, as @kevmoo is doing his talk tomorrow. |
Member
Author
|
Oh, the other PR landed. But @kevmoo doesn't that mean the instructions don't work as they assume code that is only in main but the instructions say to use beta? |
Member
Author
|
Updated this after the changes from the other PR. |
sfshaza2
reviewed
Mar 13, 2024
Member
Author
|
@sfshaza2 this was ready to be merged (sorry, I should have marked it draft). Can you please revert? |
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Mar 18, 2024
_Description of what this PR is changing or adding, and why:_ Update Wasm getting started instructions to: - Simplify a bit - Rely on the standard template to ensure they are compatible - Align with bootstrap changes landed in flutter/flutter#144434 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
_Description of what this PR is changing or adding, and why:_ Update Wasm getting started instructions to: - Simplify a bit - Rely on the standard template to ensure they are compatible - Align with bootstrap changes landed in flutter/flutter#144434 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Update Wasm getting started instructions to:
Presubmit checklist