Reflect deprecation of the HTML renderer on image CORS details#11155
Merged
parlough merged 4 commits intoflutter:mainfrom Sep 23, 2024
JaffaKetchup:patch-2
Merged
Reflect deprecation of the HTML renderer on image CORS details#11155parlough merged 4 commits intoflutter:mainfrom JaffaKetchup:patch-2
parlough merged 4 commits intoflutter:mainfrom
JaffaKetchup:patch-2
Conversation
JaffaKetchup
requested review from
a team,
parlough and
sfshaza2
as code owners
JaffaKetchup
changed the title
sfshaza2
reviewed
Sep 18, 2024
sfshaza2
approved these changes
Sep 18, 2024
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Smoothed out a sentence that was a bit hard to parse. Otherwise, LGTM. Thx!
Contributor
|
/gcbrun |
Collaborator
|
Visit the preview URL for this PR (updated for commit b928612): |
parlough
approved these changes
Sep 18, 2024
Member
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thanks so much for these adjustments!
I expect more changes will be needed in the future with Harry's work on flutter/flutter#149843, but it's nice to see some simplification to the docs in the mean time :D
Member
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Removes references to the HTML renderer (as it is being deprecated), except for a small version note. Re-organised the page to better show the reduced information load and remove redundant headings.
I believe this comes into effect with 3.25.0, at the same time as flutter/flutter#152683 is released, but #11045 has already been made, so this PR may be suitable immediately.
_Issues fixed by this PR (if any): #11154
Presubmit checklist