FIX: Broken links on "new-color-scheme-roles.md" page#11245
Merged
sfshaza2 merged 2 commits intoflutter:mainfrom Oct 8, 2024
Merged
FIX: Broken links on "new-color-scheme-roles.md" page#11245sfshaza2 merged 2 commits intoflutter:mainfrom
sfshaza2 merged 2 commits intoflutter:mainfrom
Conversation
The following four links to reference pages on the Flutter web site page https://docs.flutter.dev/release/breaking-changes/new-color-scheme-roles are broken: - [Support fidelity variant for ColorScheme.fromSeed](flutter/flutter#144649) - [Introduce tone-based surfaces and accent color add-ons - Part 1](flutter/flutter#142654) - [Introduce tone-based surfaces and accent color add-ons - Part 2](flutter/flutter#138521) - [Enhance ColorScheme.fromSeed with a new variant parameter](flutter/flutter#144805) They are broken due to wrong syntax in the markdown file, used URLs are otherwise correct, but the used extended markdown link syntax is not, causing the links to be broken. This PR fixes the error so the links work.
…eme-roles FIX: Broken links on "new-color-scheme-roles.md" page
Member
|
/gcbrun |
Collaborator
|
Visit the preview URL for this PR (updated for commit 473978c): |
Contributor
|
Yeah, those brackers in the URL are just wrong. However, those links work for me. Weird. |
Contributor
Author
|
The links with brackets did not work for me, got 404 pages for all of them. Weird. Now they all work. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following four links to reference pages on the Flutter web site page https://docs.flutter.dev/release/breaking-changes/new-color-scheme-roles are broken:
They are broken due to wrong syntax in the markdown file, used URLs are otherwise correct, but the used extended markdown link syntax is not, causing the links to be broken.
This PR fixes the error so the links work.
Presubmit checklist