Add a breaking change doc about deep links flag change to the flutter website#11493
Merged
Add a breaking change doc about deep links flag change to the flutter website#11493
Conversation
hannah-hyj
requested review from
a team,
parlough and
sfshaza2
as code owners
sfshaza2
reviewed
Dec 13, 2024
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Thanks, @hannah-hyj! A few things to fix.
Contributor
|
Also, @hannah-hyj, can you add this to the index file? |
sfshaza2
reviewed
Dec 13, 2024
|
|
||
| * Android Manifest file | ||
|
|
||
| ```dart |
Contributor
There was a problem hiding this comment.
@hannah-hyj, I believe the build is failing because you label this code as dart, when it's yaml. Can you fix this and also add "yaml" to the iOS example below. If I'm right, this should fix the website build.
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Collaborator
|
Visit the preview URL for this PR (updated for commit 0687357): https://flutter-docs-prod--pr11493-deeplinkflag-breakingchange-rs4js96k.web.app |
sfshaza2
reviewed
Dec 14, 2024
sfshaza2
approved these changes
Dec 14, 2024
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
At last, the build passes! :D LGTM. (And I meant to say that if you put the links inline you use regular parenthetical brackets, not square brackets, nor curly brackets. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add doc about the breaking change and migration guide.
Related PR: flutter/engine#52350
Presubmit checklist