Add a breaking change notice for integration_test golden-file comparisons#11716
Merged
matanlurey merged 7 commits intoflutter:mainfrom Feb 13, 2025
Merged
Conversation
matanlurey
requested review from
a team,
antfitch,
parlough and
sfshaza2
as code owners
Collaborator
|
Visit the preview URL for this PR (updated for commit 31b72a9): https://flutter-docs-prod--pr11716-integreation-test-comparato-jlz0lq2x.web.app |
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 13, 2025
…163157) Closes #143299. Closes #160043. A website update is work-in-progress here to add more context for users: <flutter/website#11716>.
sfshaza2
reviewed
Feb 13, 2025
src/content/release/breaking-changes/integration-test-default-golden-comparator.md
Show resolved
Hide resolved
…golden-comparator.md
Contributor
|
Added a missing URL to fix the broken build. |
Contributor
Author
Looks like it's still mad: Run dart run flutter_site check-link-references
Checking for broken Markdown link references...
Error: Invalid link references found!
release/breaking-changes/integration-test-default-golden-comparator/index.html:
[`goldenFileComparator`][]
[`goldenFileComparator`][]
[<code>flutter_test_config.dart</code>][flutter_test]
[<code>integration_test</code>][]
[<code>flutter test</code>][] |
sfshaza2
reviewed
Feb 13, 2025
src/content/release/breaking-changes/integration-test-default-golden-comparator.md
Outdated
Show resolved
Hide resolved
…golden-comparator.md Fixed malformed URL.
sfshaza2
reviewed
Feb 13, 2025
src/content/release/breaking-changes/integration-test-default-golden-comparator.md
Outdated
Show resolved
Hide resolved
…golden-comparator.md it's => its
sfshaza2
reviewed
Feb 13, 2025
src/content/release/breaking-changes/integration-test-default-golden-comparator.md
Show resolved
Hide resolved
…golden-comparator.md Added another missing url
sfshaza2
reviewed
Feb 13, 2025
src/content/release/breaking-changes/integration-test-default-golden-comparator.md
Outdated
Show resolved
Hide resolved
…golden-comparator.md Feel free to add this back as a link, but please define the link.
Contributor
Author
|
It still looks like, for whatever reason, the link checker doesn't understand that link. |
Contributor
Author
|
It was the header! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is more of a bug fix than a breaking change, it could break users that were expecting it not to work and have implemented workarounds. At the very least it gives a canonical place to point to "this is fixed and here is what is wrong" for customers to use.