Add breaking change doc for removing semantics elevation and thickness#12010
Merged
chunhtai merged 2 commits intoflutter:mainfrom May 15, 2025
Merged
Add breaking change doc for removing semantics elevation and thickness#12010chunhtai merged 2 commits intoflutter:mainfrom
chunhtai merged 2 commits intoflutter:mainfrom
Conversation
chunhtai
requested review from
a team,
antfitch,
parlough and
sfshaza2
as code owners
Collaborator
|
Visit the preview URL for this PR (updated for commit 1b7aa33): https://flutter-docs-prod--pr12010-remove-elevation-safey2f7.web.app |
sfshaza2
approved these changes
May 13, 2025
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
A few little nitpicky things (but please fix). Otherwise lgtm
src/content/release/breaking-changes/remove-semantics-elevation-and-thickness.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/remove-semantics-elevation-and-thickness.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/remove-semantics-elevation-and-thickness.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/remove-semantics-elevation-and-thickness.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Contributor
Author
|
Thanks for review, let's keep this open a bit until the targeting pr has lgtm from the fuchsia side |
Contributor
|
SG! |
Contributor
Author
|
merging now since i got LGTM for the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Description of what this PR is changing or adding, and why: breaking change
_Issues fixed by this PR (if any): flutter/flutter#168703
PRs or commits this PR depends on (if any):
Presubmit checklist