Skip to content

[3.35] Rename entryPointBaseUrl to entrypointBaseUrl#12134

Merged
antfitch merged 1 commit intomainfrom
mdebbar-patch-1
Aug 13, 2025
Merged

[3.35] Rename entryPointBaseUrl to entrypointBaseUrl#12134
antfitch merged 1 commit intomainfrom
mdebbar-patch-1

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 18, 2025

Blocked on landing in stable

Renaming the entryPointBaseUrl parameter to entrypointBaseUrl.

cc @piedcipher

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jun 18, 2025

Visit the preview URL for this PR (updated for commit f73526b):

https://flutter-docs-prod--pr12134-mdebbar-patch-1-j1aes97a.web.app

sfshaza2
sfshaza2 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Land when ready

@mdebbar mdebbar changed the title [3.32] Rename entryPointBaseUrl to entrypointBaseUrl [3.35] Rename entryPointBaseUrl to entrypointBaseUrl Jun 18, 2025
@sfshaza2
Copy link
Contributor

sfshaza2 commented Jun 26, 2025

@mdebbar, can we land this?

@tirth-patel-nc
Copy link
Member

tirth-patel-nc commented Jun 27, 2025

I think last hotfix was 3.32.5, this meant to be for 3.35 I guess

@mdebbar
Copy link
Contributor Author

mdebbar commented Jun 27, 2025

I think last hotfix was 3.32.5, this meant to be for 3.35 I guess

Yes, this was meant for 3.35. Initially I had [3.32] in the title which was wrong. The title is now up-to-date.

@tirth-patel-nc tirth-patel-nc marked this pull request as ready for review August 12, 2025 13:45
@tirth-patel-nc tirth-patel-nc requested review from a team, antfitch and parlough as code owners August 12, 2025 13:45
@tirth-patel-nc
Copy link
Member

tirth-patel-nc commented Aug 12, 2025

reopening as 3.35 is releasing this month

@antfitch antfitch merged commit 8ef557f into main Aug 13, 2025
9 checks passed
@antfitch antfitch deleted the mdebbar-patch-1 branch August 13, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@antfitch antfitch Awaiting requested review from antfitch

@parlough parlough Awaiting requested review from parlough

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdebbar @flutter-website-bot @sfshaza2 @tirth-patel-nc @antfitch