docs: Add page transition builder reorganization guide#12914
docs: Add page transition builder reorganization guide#12914sfshaza2 merged 2 commits intoflutter:mainfrom
Conversation
Summary of ChangesHello @rkishan516, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive documentation for a significant breaking change in Flutter's page transition builders. Specifically, it details the relocation of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new documentation page for the breaking change related to the reorganization of page transition builders. The new page is clear and well-structured. I've made a suggestion to improve conciseness. Additionally, the index.md file has been updated to include the new page, but the list of breaking changes is not alphabetically sorted as per the file's own guidelines. I've added a comment to address this maintainability issue.
src/content/release/breaking-changes/decouple-page-transition-builders.md
Outdated
Show resolved
Hide resolved
| * [Deprecate `findChildIndexCallback` in favor of `findItemIndexCallback` in `ListView` and `SliverList` separated constructors][] | ||
| * [Migrating Flutter Android app to Android Gradle Plugin 9.0.0][] | ||
| * [Material 3 tokens update][] | ||
| * [Page transition builders reorganization][] |
There was a problem hiding this comment.
The guideline on line 35 states that this list should be sorted alphabetically. The list under 'Not yet released to stable' is not currently sorted. To improve maintainability and adhere to the guideline, please sort all items in this list alphabetically. The same principle should be applied to the reference links at the bottom of the section.
|
Visit the preview URL for this PR (updated for commit c62afad): https://flutter-docs-prod--pr12914-page-transition-migration-qw30veqh.web.app |
…builders.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
3 participants
Add migration guide for page transition builders reorganisation
_PRs or commits this PR depends on (if any): flutter/flutter#179776
Changes
Presubmit checklist
of 80 characters or fewer.