Skip to content

Migration guide for ListTile color warning#13131

Merged
sfshaza2 merged 4 commits intomainfrom
list-tile-color-warning
Mar 3, 2026
Merged

Migration guide for ListTile color warning#13131
sfshaza2 merged 4 commits intomainfrom
list-tile-color-warning

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Mar 2, 2026

This PR is to add a breaking change page for flutter/flutter#181402

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@QuncCccccc QuncCccccc requested review from a team and sfshaza2 as code owners March 2, 2026 23:45
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 2, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new documentation for a breaking change related to ListTile widgets in Flutter. The new guide explains why an exception is now thrown when a ListTile is placed inside a colored widget that obscures its visual effects, and provides developers with clear migration paths to resolve this issue, ensuring proper rendering and preventing accidental bugs.

Highlights

  • New Breaking Change Documentation: A new breaking change page has been added to document an exception thrown when a ListTile is wrapped in an intermediate widget with a non-transparent background color.
  • ListTile Color Warning Explained: The documentation explains that ListTile paints its background and ink splashes on the nearest Material ancestor, and an intermediate colored widget can obscure these effects, leading to an exception.
  • Migration Guidance Provided: The guide provides clear steps to resolve the exception, either by removing the intermediate widget's background color or by wrapping the ListTile in its own Material widget.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/content/release/breaking-changes/index.md
    • Added a new entry for "ListTile throws exception when wrapped in a colored widget" to the breaking changes index.
    • Included the corresponding link definition for the new breaking change page.
  • src/content/release/breaking-changes/list-tile-color-warning.md
    • Created a new Markdown document detailing the breaking change.
    • Provided a summary, background explanation, and migration guide with code examples.
    • Included timeline information and references to relevant API documentation, issues, and PRs.
Activity
  • The author completed the presubmit checklist, indicating adherence to documentation style guidelines, semantic line breaks, and other PR requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 2, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds a new migration guide for a breaking change related to ListTile. The guide is well-written and clear. I've suggested a minor improvement to a code example to make it more concise. I also noticed that the list of breaking changes in index.md is not alphabetically sorted as stated, so I've provided a suggestion to fix the order.

@QuncCccccc QuncCccccc force-pushed the list-tile-color-warning branch from 73ba671 to a27144d Compare March 2, 2026 23:49
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 2, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1b3673b):

https://flutter-docs-prod--pr13131-list-tile-color-warning-pe5pxulh.web.app

@QuncCccccc QuncCccccc requested a review from dkwingsmt March 2, 2026 23:51
@QuncCccccc QuncCccccc mentioned this pull request Mar 2, 2026
Merged
9 tasks
sfshaza2
sfshaza2 reviewed Mar 3, 2026
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I have a couple minor edits and I'd also like you to weigh in on the bot's code suggestion, @QuncCccccc.

QuncCccccc and others added 3 commits March 2, 2026 17:53
@QuncCccccc @sfshaza2
Update src/content/release/breaking-changes/list-tile-color-warning.md
1b3673b 
Co-authored-by: Shams Zakhour <[email protected]>
@QuncCccccc @sfshaza2
Update src/content/release/breaking-changes/list-tile-color-warning.md
74549a9 
Co-authored-by: Shams Zakhour <[email protected]>
@QuncCccccc @gemini-code-assist
Update src/content/release/breaking-changes/index.md
9fb1ebf 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Mar 3, 2026

Thanks a lot for reviewing! I've accepted all the suggestions:)!

sfshaza2
sfshaza2 approved these changes Mar 3, 2026
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 4699037 into main Mar 3, 2026
10 checks passed
@sfshaza2 sfshaza2 deleted the list-tile-color-warning branch March 3, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuncCccccc @flutter-website-bot @sfshaza2