Skip to content

Added cupertino localizations#2804

Merged
sfshaza2 merged 2 commits intoflutter:masterfrom
sebastiankutschbach:sebastiankutschbach-patch-1
Jul 4, 2019
Merged

Added cupertino localizations#2804
sfshaza2 merged 2 commits intoflutter:masterfrom
sebastiankutschbach:sebastiankutschbach-patch-1

Conversation

@sebastiankutschbach
Copy link
Contributor

Added cupertino localizations in order to not run into flutter/flutter#13452

Added cupertino localizations in order to not run into flutter/flutter#13452
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Contributor has not signed the Contributor License Agreement label Jul 4, 2019
@sebastiankutschbach
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Jul 4, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Contributor has not signed the Contributor License Agreement and removed cla: yes Contributor has signed the Contributor License Agreement labels Jul 4, 2019
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Jul 4, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@sebastiankutschbach
Copy link
Contributor Author

@sfshaza2 I didn't get Travis to build correctly. Is it related to the broken build on the master branch?

@sfshaza2 sfshaza2 merged commit 0749497 into flutter:master Jul 4, 2019
@sebastiankutschbach sebastiankutschbach deleted the sebastiankutschbach-patch-1 branch July 4, 2019 20:16
matthew-carroll pushed a commit to matthew-carroll/website that referenced this pull request Jul 11, 2019
Added cupertino localizations in order to not run into flutter/flutter#13452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants