Migration guide for https://github.com/flutter/flutter/pull/47177#3430
Merged
dnfield merged 8 commits intoflutter:masterfrom Dec 17, 2019
Merged
Migration guide for https://github.com/flutter/flutter/pull/47177#3430dnfield merged 8 commits intoflutter:masterfrom
dnfield merged 8 commits intoflutter:masterfrom
Conversation
googlebot
added
the
cla: yes
13 tasks
Contributor
Author
|
CI appears to be failing on unrelated files... |
sfshaza2
reviewed
Dec 17, 2019
| ## Description of change | ||
|
|
||
| The Flutter framework tracks when the editing state of an `EditableText` widget | ||
| changes. It keeps synchronizes this value to the engine, but only if the value |
| The Flutter framework tracks when the editing state of an `EditableText` widget | ||
| changes. It keeps synchronizes this value to the engine, but only if the value | ||
| has changed. The state of this value is tracked by the `TextInputClient`, and | ||
| logic exists to prevent sending duplicative values to the engine side. |
Contributor
Author
|
@sfshaza2 - this is against the website repo :) I've linked to the related flutter/flutter PR here. |
Contributor
Author
|
Thanks - let's give Hixie and goderbauer a chance to see it :) |
goderbauer
approved these changes
Dec 17, 2019
|
|
||
| ## Migration guide | ||
|
|
||
| Tests that relied on the dirty state will have to be updated. For example, this |
Member
There was a problem hiding this comment.
maybe call out ".. dirty state from a previously run test..."?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/flutter#47177 is a breaking change no matter how I try to slice it - even if I pull out the test related changes. Provides a guide for migrating tests that this breaks.