add warning for gradual v1 deprecation#4328
Merged
sfshaza2 merged 2 commits intoflutter:masterfrom Jul 31, 2020
Merged
Conversation
googlebot
added
the
cla: yes
blasten
reviewed
Jul 11, 2020
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
blasten
reviewed
Jul 11, 2020
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
blasten
reviewed
Jul 11, 2020
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
blasten
reviewed
Jul 11, 2020
| [The Route Transition record and Transition delegate updates]: /docs/release/breaking-changes/route-transition-record-and-transition-delegate | ||
| [ThemeData's accent properties]: /docs/release/breaking-changes/theme-data-accent-properties | ||
| [Material Chip button semantics]: /docs/release/breaking-changes/material-chip-button-semantics | ||
| [Android v1 embedding app and plugin creation deprecation]: /docs/release/breaking-changes/android-v1-embedding-create-deprecation |
There was a problem hiding this comment.
nit: what about "Android v1 embedding deprecation" ?
Member
Author
There was a problem hiding this comment.
It's not a doc about v1 embedding deprecation since there still needs to be a bunch of more steps before it's deprecated. We're just deprecating the creation templates.
sfshaza2
reviewed
Jul 13, 2020
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Overall this looks good, though it needs to be modified to past tense. Glad to see the timeline info. :)
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/android-v1-embedding-create-deprecation.md
Outdated
Show resolved
Hide resolved
Contributor
|
This looks ready to merge. Yes? |
Member
Author
|
ya, thanks Shams! |
filiph
pushed a commit
to filiph/website
that referenced
this pull request
Feb 22, 2021
* add warning for gradual v1 deprecation * review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.