Add an instruction page for adding iOS App Clip#4592
Add an instruction page for adding iOS App Clip#4592sfshaza2 merged 2 commits intoflutter:masterfrom
Conversation
googlebot
added
the
cla: yes
| in the future. | ||
| {{site.alert.end}} | ||
|
|
||
| This guide describes how to manually add another Flutter-rendering iOS App Clip |
There was a problem hiding this comment.
Another? Is one already there by default?
There was a problem hiding this comment.
Ah sorry, it's not clear. There is another Flutter-rendering target already by default (their main app target).
|
Thanks Shams for the detailed review again! I did most of what you asked. Regarding the space between the headers, I was looking at the page again and thought all the headers and subheaders were a bit too obnoxious and created too much big text and space around the actual content. I made everything a bit denser with just bold text. Let me know if it's ok. |
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
This is looking good! Staged here: https://sz-flutter.firebaseapp.com/docs/development/platform-integration/ios-app-clip
Thanks for optimizing the images!
The final bit that needs fixing, is that the link to the samples app is a 404. Once that's fixed, I can land this.
|
Sounds good. Thanks for the review! I don't have the sample app yet unfortunately 😅 I'll bug Andrew tomorrow. |
|
SG! Andrew needs a little bugging. ;)
…On Wed, Sep 9, 2020 at 11:24 PM xster ***@***.***> wrote:
Sounds good. Thanks for the review!
I don't have the sample app yet unfortunately 😅
I'll bug Andrew tomorrow.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4592 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS4PKJM6T2K5SPOGHEFTDTSFBWKZANCNFSM4RBUTIUQ>
.
|
Let the record show that I was bugged forthwith by @xster. |
|
Can we remove the sample reference and update this later when we have it? The instructions are still useful without the sample app. |
|
The samples are in. Should be ready now. |
* Add an instruction page for adding iOS App Clip * review
5 participants
Fixes flutter/flutter#60029
The PNGs are opti-png'ed.