Remove pod setup instructions, note the sudoless CocoaPods install#4662
Remove pod setup instructions, note the sudoless CocoaPods install#4662sfshaza2 merged 3 commits intoflutter:masterfrom jmagman:ruby-install
Conversation
googlebot
added
the
cla: yes
| [Check the app's Bundle ID]: /images/setup/xcode-unique-bundle-id.png | ||
| [Choosing a Membership]: https://developer.apple.com/support/compare-memberships | ||
| [Mac App Store]: https://itunes.apple.com/us/app/xcode/id497799835 | ||
| [Flutter plugins]: /docs/development/packages-and-plugins/using-packages |
There was a problem hiding this comment.
I wanted to link somewhere more specific that explained what plugins were (with native code), but I couldn't really find anything. Filed #4661.
There was a problem hiding this comment.
Thanks for filing that bug, @jmagman. The info is a bit buried on the developing packages page, but both could use some clarification.
There was a problem hiding this comment.
Ah ha, there it is! Will update the link to that anchor.
| $ sudo gem install cocoapods | ||
| $ pod setup | ||
| ``` | ||
| {{site.alert.note}} |
There was a problem hiding this comment.
@sfshaza2 Would you mind deploying this so we can check if this note messed up the numbering? I know we've needed to add ols in a few places.
There was a problem hiding this comment.
random tangent: you don't need to deploy it to check formatting. You can just follow https://github.com/flutter/website#developing locally.
There was a problem hiding this comment.
@xster is correct! Just run the script in tool/serve.sh and you can view it on localhost. You just can't share that link with others. :)
There was a problem hiding this comment.
I'm not willing to install nvm and rvm on my development machine. See: this very diff for all the versioning trouble it causes.
There was a problem hiding this comment.
ya, it's definitely a hassle. Though on the flip side, fwiw, I never managed to get ruby or python with a reasonably high version to install nicely on mac either without their own ruby or python specific version manager.
There was a problem hiding this comment.
You're right, I didn't need rvm, I was just missing jekyll and npx.
There was a problem hiding this comment.
This had two #1s, I changed it to ol and lis, now it increments to 1 and 2, and the alphabetized {: type="a"} also looks right.
| ``` | ||
| {{site.alert.note}} | ||
| The default version of Ruby requires `sudo` to install the CocoaPods gem. | ||
| If you are using a Ruby Version manager, you may need to run without `sudo`. |
There was a problem hiding this comment.
I'm under the impression you need 2 indents inside these alerts
| $ sudo gem install cocoapods | ||
| $ pod setup | ||
| ``` | ||
| {{site.alert.note}} |
There was a problem hiding this comment.
random tangent: you don't need to deploy it to check formatting. You can just follow https://github.com/flutter/website#developing locally.
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
A couple of minor comments.
| you will also need the third-party CocoaPods dependency manager. | ||
|
|
||
| 1. Install and set up CocoaPods by running the following commands: | ||
| 1. You may skip this step if your apps do not depend on |
There was a problem hiding this comment.
We avoid "may".
=? You can skip this...
| [Check the app's Bundle ID]: /images/setup/xcode-unique-bundle-id.png | ||
| [Choosing a Membership]: https://developer.apple.com/support/compare-memberships | ||
| [Mac App Store]: https://itunes.apple.com/us/app/xcode/id497799835 | ||
| [Flutter plugins]: /docs/development/packages-and-plugins/using-packages |
There was a problem hiding this comment.
Thanks for filing that bug, @jmagman. The info is a bit buried on the developing packages page, but both could use some clarification.
|
Ready for re-review, @sfshaza2! |
…lutter#4662) * Remove pod setup instructions, note the sudoless CocoaPods install * Review edits * Fix numbering
4 participants
pod setupis no longer required as of CocoaPods 1.8. Remove it.sudo.flutter/flutter#10122 (comment)
Fixes flutter/flutter#65131.