Skip to content

Add breaking change "Use maxLengthEnforcement instead of maxLengthEnforced"#4883

Merged
AlexV525 merged 24 commits intoflutter:masterfrom
AlexV525:add-breaking-change-composing-truncate
Jan 13, 2021
Merged

Add breaking change "Use maxLengthEnforcement instead of maxLengthEnforced"#4883
AlexV525 merged 24 commits intoflutter:masterfrom
AlexV525:add-breaking-change-composing-truncate

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Oct 15, 2020 •
edited
Loading

Migration guide for flutter/flutter#63754 and flutter/flutter#68086 .

Changes proposed in these pull requests:

  • Add the migration guide for MaxLengthEnforcement about the composing editing value truncate behavior.

This may also require a public announcement.

Design doc: https://docs.google.com/document/d/1S900lQaTPOsePnIeE7o3-Ia8f39VZaSv0JnjNyBfCvU

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Oct 15, 2020
@AlexV525 AlexV525 mentioned this pull request Oct 15, 2020
Merged
13 tasks
@AlexV525 AlexV525 marked this pull request as draft October 16, 2020 07:03
@AlexV525 AlexV525 changed the title Add breaking change "Composing value won't be truncated by default" Add breaking change "Use maxLengthEnforcement instead of maxLengthEnforced" Oct 17, 2020
@AlexV525 AlexV525 marked this pull request as ready for review October 17, 2020 16:09
@AlexV525 AlexV525 marked this pull request as draft October 18, 2020 02:57
sfshaza2
sfshaza2 requested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback for you.

@AlexV525
Copy link
Member Author

AlexV525 commented Oct 19, 2020

@sfshaza2 The PR is still changing and not stabled yet so I draft this. Sorry for the early review request 😢

@AlexV525 AlexV525 requested a review from justinmc October 27, 2020 06:01
justinmc
justinmc reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small improvements I saw.

@AlexV525 AlexV525 marked this pull request as ready for review December 8, 2020 13:00
justinmc
justinmc approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical point of view. The migration guide looks accurate and up-to-date with the new plan for the PR.

@AlexV525 AlexV525 requested a review from sfshaza2 December 9, 2020 23:33
@AlexV525
Copy link
Member Author

AlexV525 commented Dec 11, 2020

MaxLengthEnforcement doc is exist on master-api now.

LongCatIsLooong
LongCatIsLooong reviewed Dec 11, 2020
View reviewed changes
@AlexV525
Copy link
Member Author

AlexV525 commented Dec 12, 2020 •
edited
Loading

Can I add some screenshots to explain more details about text fields behavior? Forget this.

LongCatIsLooong
LongCatIsLooong reviewed Dec 15, 2020
View reviewed changes
LongCatIsLooong
LongCatIsLooong reviewed Jan 6, 2021
View reviewed changes
@AlexV525
Copy link
Member Author

AlexV525 commented Jan 6, 2021

@sfshaza2 Could you take another look?

LongCatIsLooong
LongCatIsLooong approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay.

@AlexV525 AlexV525 merged commit 4664763 into flutter:master Jan 13, 2021
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
@AlexV525 @filiph
Add breaking change "Use maxLengthEnforcement instead of maxLengthEnf…
934ca40 
…orced" (flutter#4883)
@AlexV525 AlexV525 deleted the add-breaking-change-composing-truncate branch April 10, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedromassango pedromassango pedromassango left review comments

@justinmc justinmc justinmc approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2

Assignees

No one assigned

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlexV525 @justinmc @LongCatIsLooong @pedromassango @sfshaza2