Add to app prebuilt binaries as xcframeworks#4956
Merged
sfshaza2 merged 2 commits intoflutter:masterfrom Nov 5, 2020
jmagman:xcframework
Merged
Add to app prebuilt binaries as xcframeworks#4956sfshaza2 merged 2 commits intoflutter:masterfrom jmagman:xcframework
sfshaza2 merged 2 commits intoflutter:masterfrom
jmagman:xcframework
Conversation
google-cla
bot
added
the
cla: yes
Member
|
LGTM. Did you optipng the image? Slightly surprised the similar dimension image doubled in size. |
Member
Author
I tried |
Member
xster
approved these changes
Nov 5, 2020
Member
Author
It's 150% larger instead of 190% now, but it's still only 162KB. |
filiph
pushed a commit
to filiph/website
that referenced
this pull request
Feb 22, 2021
* Add to app prebuilt binaries as xcframeworks * optipng
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update add-to-app iOS instructions to use
flutter build ios-framework --xcframeworkin anticipation of Apple Silicon support.--xcframeworkbecame the default as of flutter/flutter#69720.New image:
Samples also updated at flutter/samples#582.