Migration Guide for Flutter web slotted rendering.#5928
Merged
sfshaza2 merged 4 commits intoflutter:masterfrom Jun 21, 2021
ditman:slots-in-web
Merged
Migration Guide for Flutter web slotted rendering.#5928sfshaza2 merged 4 commits intoflutter:masterfrom ditman:slots-in-web
sfshaza2 merged 4 commits intoflutter:masterfrom
ditman:slots-in-web
Conversation
google-cla
bot
added
the
cla: yes
yjbanov
reviewed
Jun 16, 2021
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
sfshaza2
requested changes
Jun 16, 2021
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Yegor made some comments that I turned into official GitHub suggestions. He also had some questions as to the design, and I will leave that to the two of you to resolve. :)
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/platform-views-using-html-slots-web.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Member
Author
|
Thanks @sfshaza2 for the suggestions! I was halfway through applying by hand Yegor's suggestions so I took the ones from you that wouldn't directly conflict with my changes :P I've manually applied your changes to the first half of the doc, I think I got'em'all! |
sfshaza2
approved these changes
Jun 16, 2021
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
LGTM, but I will let Yegor have the final say.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a Migration Guide for the new Flutter web slotted rendering, explaining how the code is changing and what users need to do for their web apps to keep working as normal.
Fixes: flutter/flutter#80524