Page transitions replaced by ZoomPageTransitionsBuilder#6646
Merged
sfshaza2 merged 9 commits intoflutter:mainfrom Apr 7, 2022
Merged
Page transitions replaced by ZoomPageTransitionsBuilder#6646sfshaza2 merged 9 commits intoflutter:mainfrom
sfshaza2 merged 9 commits intoflutter:mainfrom
Conversation
8 tasks
AlexV525
changed the title
Hixie
reviewed
Jan 10, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
Hixie
reviewed
Jan 10, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
Hixie
reviewed
Jan 10, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
Hixie
reviewed
Jan 10, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
Hixie
reviewed
Jan 10, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
Hixie
reviewed
Jan 10, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
Hixie
reviewed
Jan 18, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Show resolved
Hide resolved
Contributor
|
Learning more about the underlying PR, I think this doc needs to include the error message that happens when you find a Transform (or other widgets that we're introducing now), whereas previously you did not, and it should show how to fix it (e.g. using find.descendant). |
Contributor
|
(the idea of these docs is that people google error messages and we want to give them the answer as soon as they do so) |
AlexV525
requested review from
domesticmouse,
johnpryan,
khanhnwin and
kwalrath
as code owners
Member
Author
|
I've added the tests migration and pointed out a few widgets related to this transition that might require migration. |
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
In general this LGTM, but I believe it should be held until after the next stable release.
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Show resolved
Hide resolved
domesticmouse
approved these changes
Jan 25, 2022
Contributor
|
PTAL @sfshaza2 |
sfshaza2
requested changes
Jan 27, 2022
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Just a few grammatical edits and one clarification needed. thx!
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Show resolved
Hide resolved
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Member
Author
|
Thanks @domesticmouse and @sfshaza2! The last step is to wait until the PR landed. |
Member
Author
|
(as per flutter/flutter#96375 (comment)) |
8 tasks
8 tasks
AlexV525
force-pushed
the
breaking-zoom-page-transition
branch
from
61c586d to
94cb653
Compare
# Conflicts: # src/release/breaking-changes/index.md
Member
Author
|
The PR has been landed. Removing the WIP label for further review. |
This comment was marked as off-topic.
This comment was marked as off-topic.
AlexV525
commented
Mar 31, 2022
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/page-transition-replaced-by-ZoomPageTransitionBuilder.md
Outdated
Show resolved
Hide resolved
domesticmouse
approved these changes
Mar 31, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The breaking change note for flutter/flutter#100812.
Presubmit checklist