[cookbook] Update websocket URL.#6933
Merged
domesticmouse merged 1 commit intoflutter:mainfrom Mar 18, 2022
ditman:fix-websocket-example
Merged
[cookbook] Update websocket URL.#6933domesticmouse merged 1 commit intoflutter:mainfrom ditman:fix-websocket-example
domesticmouse merged 1 commit intoflutter:mainfrom
ditman:fix-websocket-example
Conversation
ditman
requested review from
domesticmouse,
johnpryan,
khanhnwin and
sfshaza2
as code owners
Member
Author
|
PS: I didn't run I think I was looking at the CONTRIBUTING, but ended up finding info in the README and here: |
Member
Author
|
OK after initializing the submodules, I could successfully run: |
domesticmouse
approved these changes
Mar 18, 2022
Contributor
|
Thanks so much, @ditman! We do have a how-to for refreshing the code excerpts, but it's on the site-shared repo, which might be hard to find. |
Member
Author
|
@sfshaza2 yes, I expected to find some info on the CONTRIBUTING.md but it was in the README.md (which is probably what people read anyways 😜) |
Contributor
|
Definitely the README is more widely read! :D
…On Mon, Mar 21, 2022 at 11:39 AM David Iglesias ***@***.***> wrote:
@sfshaza2 <https://github.com/sfshaza2> yes, I expected to find some info
on the CONTRIBUTING.md but it was in the README.md (which is probably what
people read anyways 😜)
—
Reply to this email directly, view it on GitHub
<#6933 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS4PKK5AHQIYCXHPDXNAQLVBC675ANCNFSM5RAQH3IQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
AlexV525
pushed a commit
to AlexV525/flutter-website
that referenced
this pull request
Mar 26, 2022
11 tasks
This was referenced Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old websocket URL used by the cookbook (
wss://echo.websocket.org) has been taken down.This PR updates it with a working echo websocket (
wss://echo.websocket.events), graciously provided by Lob, here:Issues fixed by this PR (if any):
Fixes #6382
Presubmit checklist