Fastlane: build Xcode project only once#7012
Fastlane: build Xcode project only once#7012sfshaza2 merged 3 commits intoflutter:mainfrom maxlapides:patch-1
Conversation
Fortunately, we don't have to rebuild the entire iOS project anymore :) It actually looks like we will be able to update these docs again in the near future after @jmagman's PR flutter/flutter#97672 lands on stable. At that point, most projects can skip the `fastlane build_app` step altogether. It may be worth mentioning that `build_app` can be used to set Xcode values like `configuration` which is really helpful if you are using fastlane match and you want to have separate configurations for ad-hoc vs app store builds (without authoring a plist file).
|
@jmagman, this lgtm, and I see that the reference PR is merged. Can we go ahead and land this? |
jmagman
left a comment
There was a problem hiding this comment.
I'm not a fastlane expert but this LGTM from my reading of https://docs.fastlane.tools/actions/build_ios_app/. Thanks for the contribution @maxlapides!
jmagman
left a comment
There was a problem hiding this comment.
@maxlapides below under Running deployment locally it says:
flutter build ios --release --no-codesign. No need to sign now since fastlane will sign when archiving.
Based on this lane, is that still the right command? I didn't add --no-codesign to flutter build ipa but maybe I should add that.
@jmagman Great catch! I just updated that command to be But, to answer your question, I do think it would be great if we could have the |
|
Since you only need the |
|
@jmagman Yes I think that I haven't tested out our build after your PR that adds automatic settings for the export options plist, but I assume that we will still want to use fastlane's |
|
Or, perhaps |
jmagman
left a comment
There was a problem hiding this comment.
@jmagman Yes I think that
--skip-ipaflag would also be helpful for us :) Our use case is we want to runflutter build ipato build an xcarchive, then run fastlane'sbuild_apptwice: once for an ad-hoc build, then once for an app store build.I haven't tested out our build after your PR that adds automatic settings for the export options plist, but I assume that we will still want to use fastlane's
build_appafterflutter build ipabecause it gives us easy control over the Xcode settings.
Okay, let's take the conversation to the Flutter GitHub issue tracker instead of this website PR.
@sfshaza2 this still LGTM
sfshaza2
left a comment
There was a problem hiding this comment.
As per Jenn, lgtm. Thanks so much, @maxlapides!
Fortunately, we don't have to rebuild the entire iOS project anymore :)
It actually looks like we will be able to update these docs again in the near future after @jmagman's PR flutter/flutter#97672 lands on stable. At that point, most projects can skip the
fastlane build_appstep altogether.It may be worth mentioning that
build_appcan be used to set Xcode values likeconfigurationwhich is really helpful if you are using fastlane match and you want to have separate configurations for ad-hoc vs app store builds (without authoring a plist file).Description of what this PR is changing or adding, and why:
Issues fixed by this PR (if any):
Presubmit checklist