Add Windows to platform channel example#7328
Merged
Conversation
This adds a Windows section to the existing iOS and Android section, following the same structure as those examples, and using the code from flutter/flutter#106754 Part of flutter/flutter#79204
stuartmorgan-g
requested review from
domesticmouse,
johnpryan,
khanhnwin and
sfshaza2
as code owners
stuartmorgan-g
commented
Jun 30, 2022
| if device.batteryState == UIDevice.BatteryState.unknown { | ||
| result(FlutterError(code: "UNAVAILABLE", | ||
| message: "Battery info unavailable", | ||
| message: "Battery level not available.", |
Contributor
Author
There was a problem hiding this comment.
This is an opportunistic fix; there was a pointless minor inconsistency between the Android and iOS examples here, so I unified them to use the same message.
sfshaza2
approved these changes
Jun 30, 2022
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm. Thanks again, @stuartmorgan!
stuartmorgan-g
added a commit
that referenced
this pull request
Jan 20, 2023
This adds a Linux section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#108068 This is the Linux equivalent of #7328 Part of flutter/flutter#79204
sfshaza2
added a commit
that referenced
this pull request
Jan 26, 2023
* Add Linux to platform channel example This adds a Linux section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#108068 This is the Linux equivalent of #7328 Part of flutter/flutter#79204 * Update src/development/platform-integration/platform-channels.md Co-authored-by: Loïc Sharma <[email protected]> * Update src/development/platform-integration/platform-channels.md Co-authored-by: Loïc Sharma <[email protected]> * Update src/development/platform-integration/platform-channels.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> * Update src/development/platform-integration/platform-channels.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> * Update src/development/platform-integration/platform-channels.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
stuartmorgan-g
added a commit
that referenced
this pull request
Apr 5, 2023
This adds a macOS section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#123141 This is the macOS equivalent of #7328 and #8127 Fixes flutter/flutter#79204
3 tasks
sfshaza2
pushed a commit
that referenced
this pull request
Apr 5, 2023
This adds a macOS section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#123141 This is the macOS equivalent of #7328 and #8127 Fixes flutter/flutter#79204 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/master/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Windows section to the existing iOS and Android section, following the same structure as those examples, and using the code from flutter/flutter#106754
Part of flutter/flutter#79204
Presubmit checklist