Make splashScreenView of FlutterViewController nullable#7385
Merged
khanhnwin merged 2 commits intoflutter:mainfrom Jul 27, 2022
Merged
Make splashScreenView of FlutterViewController nullable#7385khanhnwin merged 2 commits intoflutter:mainfrom
khanhnwin merged 2 commits intoflutter:mainfrom
Conversation
zhongwuzw
requested review from
domesticmouse,
johnpryan,
khanhnwin and
sfshaza2
as code owners
8 tasks
jmagman
reviewed
Jul 21, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Thanks for the migration change @zhongwuzw! Rearranged this a bit. The tech writers will also take a look.
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Outdated
Show resolved
Hide resolved
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Show resolved
Hide resolved
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Outdated
Show resolved
Hide resolved
Contributor
|
PTAL @sfshaza2 |
cyanglaz
reviewed
Jul 21, 2022
src/release/breaking-changes/ios-flutterviewcontroller-splashscreenview-nullable.md
Outdated
Show resolved
Hide resolved
Member
Author
Member
|
@khanhnwin can we get this merged? Is another review needed? |
Contributor
|
I wanted to make sure @sfshaza2 got a chance to review the language, but since she's OOO and this PR has been sitting for a while, I can go ahead and merge. Shams, let me know if you want to make any retroactive language changes! |
khanhnwin
approved these changes
Jul 27, 2022
Contributor
|
Merged. Thanks @zhongwuzw @cyanglaz @jmagman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make splashScreenView of FlutterViewController nullable flutter/engine#34743.
We should make splashScreenView nullable, then Swift users can remove splashScreenView if they set nil.
Presubmit checklist