Merged
Conversation
This adds a macOS section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#123141 This is the macOS equivalent of #7328 and #8127 Fixes flutter/flutter#79204
stuartmorgan-g
requested review from
atsansone,
domesticmouse,
johnpryan,
khanhnwin,
parlough and
sfshaza2
as code owners
sfshaza2
approved these changes
Apr 5, 2023
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
This is excellent, Stuart. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a macOS section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#123141
This is the macOS equivalent of #7328 and #8127
Fixes flutter/flutter#79204
Presubmit checklist