Conversation
|
Visit the preview URL for this PR (updated for commit ac8e5c6): https://flutter-docs-prod--pr8944-layout-ut4no4td.web.app (expires Mon, 31 Jul 2023 16:56:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
|
(This would be easier to review if the whitespace/wrapping changes were done separate from the content changes, so we could more easily notice when content had changed.) |
sfshaza2
added
review.tech
|
@goderbauer, could you take another look? thx |
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
Overall this looks good. I just don't know how we can link to the relevant section about unconstrained bounds from the error message now (see comments in the PR).
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thanks for these adjustments and cleanup! Love it!
A few minor fixes and can you also remove box-constraints from the sidenav: https://github.com/flutter/website/blob/main/src/_data/sidenav.yml#L83-L84
parlough
added
st.RFM.%
sfshaza2
removed
the
st.RFM.%
|
Just for posterity when we're following breadcrumbs later, what was the conclusion for what we want to do with the error message that points to these pages? Did we add a redirect for people with old versions of Flutter? Are we updating newer versions of Flutter? |
|
https://flutter.dev/layout still redirects to the unbounded constraints section, but we should consider adding a new, more specific redirect to switch to since flutter.dev/layout seems like a valuable path to have open eventually. \cc @sfshaza2 |
|
Yes, I'd like to add a new specific redirect. I plan to file an issue. |
|
Filed: flutter/flutter#130805 |
Tooling (will) point to flutter.dev/unbounded-constraints, which is a shortcut for a longer link. Related PR: #8944 and: flutter/flutter#130805
Fixes flutter#7701 @Hixie, I'd like your input on this. The original request was to merge the box-constraints page (which you wrote many moons ago) with the Understanding constraints page (written by a third party much more recently.) I took it even further and I'd like your sign off. This PR: - Removes the box-constraints page. - Beefs up the Understanding constraints page. Added (with some significant rewording) sections from the OG box-constraints page on Unbounded constraints and Flex sections to the Understanding constraints page. I _believe_ that all the info on the original box-constraints page is now covered. - Elevates the "Common framework errors" page. I've set up a redirect so that the previous box-constraints page, now points to the common errors page. (If this all meets with your approval, I'll file a bug to update the tooling to direct to this page.) The common errors page mostly covers layout issues and how to fix them. That's all I can think of that I've done in this PR. I really appreciate your review! @goderbauer, if you are the right person to review this, please take a look! Otherwise, please ignore. :D
5 participants
Fixes #7701
@Hixie, I'd like your input on this. The original request was to merge the box-constraints page (which you wrote many moons ago) with the Understanding constraints page (written by a third party much more recently.)
I took it even further and I'd like your sign off. This PR:
That's all I can think of that I've done in this PR. I really appreciate your review!
@goderbauer, if you are the right person to review this, please take a look! Otherwise, please ignore. :D