[breaking-change] Updated default text styles for the menus#9236
[breaking-change] Updated default text styles for the menus#9236parlough merged 5 commits intoflutter:mainfrom TahaTesser:menus_text_style_breaking_change
Conversation
TahaTesser
requested review from
atsansone,
parlough and
sfshaza2
as code owners
|
cc: @rydmike |
There was a problem hiding this comment.
Thanks for always being on top of these breaking change/migration guides!
I haven't taken a close look yet, but can you add this to "Not yet released to stable" in the index: https://github.com/flutter/website/blob/main/src/release/breaking-changes/index.md?plain=1#L32
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm with a couple minor edits. @TahaTesser, is this part of the stable release for 3.13? You link to the current API, rather than the master channel API. Have these changes already been landed in the API docs?
@sfshaza2 No, the change has not landed. It is linked in the description: flutter/flutter#131930 |
I think we can add to the "Not yet released to stable" section when flutter/flutter#131930 lands and we've a build tag. |
|
flutter/flutter#131930 landed last night however we don't have the version tag yet. |
|
Thanks for the update! Should be ready to land this soon then :D |
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thank you. Looks good to me!
I added the "Landed in" version and added the page to the index.
|
@parlough Appreciate it! |
…9236) Breaking change migration for flutter/flutter#131930 --------- Co-authored-by: Parker Lougheed <[email protected]>
5 participants
Breaking change migration for flutter/flutter#131930
Presubmit checklist