Add a breaking change/migration for Paint.enableDithering.#9362
Add a breaking change/migration for Paint.enableDithering.#9362matanlurey merged 22 commits intoflutter:mainfrom
Paint.enableDithering.#9362Conversation
matanlurey
requested review from
atsansone,
parlough and
sfshaza2
as code owners
|
Apologies, my markdown formatter thrashed the index. I'll fix that right now. |
| migration guide, but you can find some resources and examples: | ||
|
|
||
| - [Writing and using fragment shaders][] | ||
| - [`linear_gradient_ssbo_fill.frag`] |
There was a problem hiding this comment.
This is sort of a bad example because it uses features that aren't exposed in the regular fragment program API. A better example might be something like:
https://github.com/jonahwilliams/awesome_gradients/blob/main/shaders/hsl_linear_gradient.frag
There was a problem hiding this comment.
Oh ok, great, thanks for pointing that out! Fixed.
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Does this flag have any impact on the CanvasKit or HTML backends?
Good question: I don't believe web ever plumbed |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM, but perhaps add a note with a link to any web bugs or caveat that web renderers will behave differently
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
A few edits to tighten the prose and more closely follow the Google Developer Doc Style guidelines.
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
|
Friendly ping @sfshaza2. |
…#9362) As written. Thanks! --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
3 participants
As written. Thanks!