Announce a breaking change of added dispose().#9397
Conversation
|
Visit the preview URL for this PR (updated for commit d0cd593): https://flutter-docs-prod--pr9397-polina-c-dispose-h8iaiomp.web.app (expires Mon, 25 Sep 2023 18:16:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
polina-c
changed the title
dispose().
polina-c
requested review from
atsansone,
parlough and
sfshaza2
as code owners
| If you got error like `Once you have called dispose() on a <class name>, it can no longer be used.`, | ||
| and the error is raised for your code, | ||
| update the code to call `dispose()' only in cases when your code created the object. |
There was a problem hiding this comment.
issue: Write as shorter sentences per GSG.
| If you got error like `Once you have called dispose() on a <class name>, it can no longer be used.`, | |
| and the error is raised for your code, | |
| update the code to call `dispose()' only in cases when your code created the object. | |
| If the following error was raised for your code, | |
| update the code to call `dispose()' only in cases when your code created the object. | |
| ```nocode | |
| Once you have called dispose() on a <class name>, it can no longer be used. | |
| ``` |
There was a problem hiding this comment.
Please fix the grammar:
If you encounter the following error, then check for
that condition:
Once you have called dispose() on a <class name>, it can no longer be used.
There was a problem hiding this comment.
Shams, in most cases, the code should not be removed, but condition should be added. So, it should be fixed, not removed.
atsansone
added
the
st.RFM.%
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
A few grammatical improvements.
| If you got error like `Once you have called dispose() on a <class name>, it can no longer be used.`, | ||
| and the error is raised for your code, | ||
| update the code to call `dispose()' only in cases when your code created the object. |
There was a problem hiding this comment.
Please fix the grammar:
If you encounter the following error, then check for
that condition:
Once you have called dispose() on a <class name>, it can no longer be used.
Co-authored-by: Anthony Sansone <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
LGTM, but @goderbauer should review before merge
parlough
removed
the
st.RFM.%
6 participants
Discussion: https://docs.google.com/document/d/1ec5djPP14b1u93O9fHrJJf3gbONay1nV4sBV2-XXOIw/edit?resourcekey=0-CFEu4HWAW8yP0knhoVfKxQ
This announce is added as already released, because we are adding
disposealready long time and some of the changes may be already released: flutter/devtools#3951Tech writers, please do not merge this before tech sign off. @goderbauer , can you review please?