Merged
Conversation
chunhtai
requested review from
MaryaBelanger,
atsansone,
domesticmouse,
parlough and
sfshaza2
as code owners
Collaborator
|
Visit the preview URL for this PR (updated for commit 79ed2f8): |
8 tasks
atsansone
added
review.copy
sfshaza2
reviewed
Dec 4, 2023
|
|
||
| ## Timeline | ||
|
|
||
| Landed in version: TBD |
Contributor
Author
There was a problem hiding this comment.
will update after the change is merged
Contributor
|
Also, @chunhtai, please add this breaking change to the index page under "Not yet released to stable". thx! |
Contributor
Author
|
will reopen once i am back from vacation |
chunhtai
commented
Apr 12, 2024
|
|
||
| ## Timeline | ||
|
|
||
| Landed in version: TBD |
Contributor
Author
There was a problem hiding this comment.
will fill this out when pr merges. It would require internal migration, so may take some time
sfshaza2
reviewed
Apr 12, 2024
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Overall, looks very good! Just a few fixes to smooth out the language.
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2024
Adds a generic type and pop result to popscope and its friend. The use cases are to be able to capture the result when the pop is called. migration guide: flutter/website#9872
8 tasks
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2024
Reverts: #139164 Initiated by: chunhtai Reason for reverting: hard breaking change Original PR Author: chunhtai Reviewed By: {justinmc} This change reverts the following previous change: Adds a generic type and pop result to popscope and its friend. The use cases are to be able to capture the result when the pop is called. migration guide: flutter/website#9872
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
Adds a generic type and pop result to popscope and its friend. The use cases are to be able to capture the result when the pop is called. migration guide: flutter/website#9872
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#147015) Reverts: flutter#139164 Initiated by: chunhtai Reason for reverting: hard breaking change Original PR Author: chunhtai Reviewed By: {justinmc} This change reverts the following previous change: Adds a generic type and pop result to popscope and its friend. The use cases are to be able to capture the result when the pop is called. migration guide: flutter/website#9872
sfshaza2
changed the title
sfshaza2
approved these changes
Apr 26, 2024
|
|
||
| ## Summary | ||
|
|
||
| Added a generic type in [`PopScope`][] class and updated the [`onPopInvoked`][] |
Contributor
There was a problem hiding this comment.
Suggested change
| Added a generic type in [`PopScope`][] class and updated the [`onPopInvoked`][] | |
| Added a generic type in the [`PopScope`][] class and updated the [`onPopInvoked`][] |
Comment on lines
+16
to
+17
| was called. The generic type is added to the `PopScope` class | ||
| so that `onPopInvoked` can access the type-safe result. |
Contributor
There was a problem hiding this comment.
Suggested change
| was called. The generic type is added to the `PopScope` class | |
| so that `onPopInvoked` can access the type-safe result. | |
| was called. The generic type added to the `PopScope` class | |
| enables `onPopInvoked` access the type-safe result. |
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 29, 2024
waiting for flutter/flutter#139164 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waiting for flutter/flutter#139164
Presubmit checklist