Fix migration guide for "deprecated gradle plugin apply"#9907
Merged
bartekpacia merged 4 commits intomainfrom Dec 8, 2023
Merged
Fix migration guide for "deprecated gradle plugin apply"#9907bartekpacia merged 4 commits intomainfrom
bartekpacia merged 4 commits intomainfrom
Conversation
bartekpacia
requested review from
MaryaBelanger,
atsansone,
domesticmouse,
parlough and
sfshaza2
as code owners
bartekpacia
changed the title
domesticmouse
approved these changes
Dec 8, 2023
bartekpacia
changed the title
Collaborator
|
Visit the preview URL for this PR (updated for commit 5ffdd76): https://flutter-docs-prod--pr9907-fix-migration-guide-gradle-p-f53g480f.web.app |
bartekpacia
force-pushed
the
fix/migration_guide_gradle_plugin_apply
branch
from
41f1503 to
5ffdd76
Compare
parlough
approved these changes
Dec 8, 2023
Member
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thanks for fixing these and adding the index link.
It's a bit awkward to read diffs of diff code blocks :P
Member
Author
|
Haha, yes :) It's a pity the docs website doesn't highlight diffs with red and green. You know if there's an issue tracking that off the top of your head? |
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Dec 11, 2023
This PR fixes errors in the migration guide: - missing entry for this guide from _index_ ([link](https://docs.flutter.dev/release/breaking-changes#not-yet-released-to-stable)) - {agpVersion} and {kotlinVersion} not displaying ([link](https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply)) Original PR flutter#9857 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. ## Preview [here](https://flutter-docs-prod--pr9907-fix-migration-guide-gradle-p-f53g480f.web.app/release/breaking-changes/flutter-gradle-plugin-apply#google-mobile-services-and-crashlytics)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes errors in the migration guide:
Original PR #9857
Presubmit checklist
Preview
here