Skip to content

fix: sub-navigation sorting in docs#3415

Merged
mattinannt merged 2 commits intomainfrom
feature/fix-docs-links
Oct 10, 2024
Merged

fix: sub-navigation sorting in docs#3415
mattinannt merged 2 commits intomainfrom
feature/fix-docs-links

Conversation

@mattinannt
Copy link
Member

@mattinannt mattinannt commented Oct 10, 2024

This pull request includes changes to improve the navigation and links in the documentation, ensuring a more consistent and user-friendly experience. The most important changes include updating broken links, removing unnecessary sorting of navigation links, and fixing the paths for self-hosting documentation.

Documentation link updates:

Navigation improvements:

Summary by CodeRabbit

  • New Features

    • Updated FAQ component for easier navigation to self-hosting resources.
    • Enhanced the Formbricks Open Source Contribution Guide with clearer metadata and updated URL paths for Gitpod and GitHub Codespaces.
  • Bug Fixes

    • Minor formatting and typographical corrections in documentation.
  • Refactor

    • Simplified navigation handling in the Navigation component for improved performance and maintainability.

@vercel
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 10:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 10:35pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Walkthrough

The pull request includes updates to three files: FAQ.tsx, page.mdx, and Navigation.tsx. The FAQ.tsx file modifies a hyperlink for self-hosting Formbricks. The page.mdx file enhances the Open Source Contribution Guide's metadata and updates URL paths for Gitpod and GitHub Codespaces. Lastly, the Navigation.tsx file simplifies navigation link handling by removing a sorting variable, allowing direct mapping of links. Minor formatting and layout adjustments are also included across the files.

Changes

File Path Change Summary
apps/docs/app/developer-docs/contributing/get-started/components/FAQ.tsx Updated hyperlink for self-hosting Formbricks to a simplified URL path.
apps/docs/app/developer-docs/contributing/get-started/page.mdx Rephrased metadata title and description; updated absolute URL paths for Gitpod and GitHub Codespaces; minor formatting adjustments.
apps/docs/components/Navigation.tsx Simplified navigation link handling by removing sorting; adjusted layout and presentation without altering core functionality.

Possibly related PRs

  • fix: update broken links in CONTRIBUTING.md #3298: The changes in the CONTRIBUTING.md file include updates to links related to Gitpod and Codespaces, which are also mentioned in the page.mdx modifications of the main PR, indicating a focus on improving navigation paths for contributors.

Suggested labels

bug, enhancement, 🕹️ oss.gg, 🕹️ 50 points

Suggested reviewers

  • jobenjada

Poem

🐰 In the land of code where rabbits play,
Links were changed to brighten the day.
With paths now clear, our docs will shine,
Helping all contributors, one at a time!
Hops and skips, through pages we go,
Together we build, together we grow! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between abc4c7f and 27d499a.

📒 Files selected for processing (3)
  • apps/docs/app/developer-docs/contributing/get-started/components/FAQ.tsx (1 hunks)
  • apps/docs/app/developer-docs/contributing/get-started/page.mdx (1 hunks)
  • apps/docs/components/Navigation.tsx (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
apps/docs/app/developer-docs/contributing/get-started/page.mdx (1)

Line range hint 3-7: LGTM! Metadata improvements enhance clarity and engagement.

The updated title and description in the metadata provide a more comprehensive and engaging overview of the contribution process. This aligns well with the PR objective of enhancing documentation.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~41-~41: Possible missing comma found.
Context: ...er** to explore and develop. For junior developers we suggest using either of these, becau...

(AI_HYDRA_LEO_MISSING_COMMA)


[formatting] ~41-~41: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...elopers we suggest using either of these, because you can dive into coding within minutes...

(COMMA_BEFORE_BECAUSE)

apps/docs/components/Navigation.tsx (1)

188-188: LGTM! Verify the impact on link order.

The removal of the sortedLinks variable simplifies the code and aligns with the PR objective of removing unnecessary sorting of navigation links within groups. This change should improve performance slightly by avoiding an unnecessary sort operation.

To ensure this change doesn't negatively impact the user experience, please verify that the order of links in the navigation still makes sense and follows a logical structure. Run the following script to check the order of links in the navigation configuration:

control over data and compliance. And the best part? Self-hosting is available for free, always. For
documentation on self hosting, click{" "}
<a href="/docs/self-hosting/deployment" className="text-brand-dark dark:text-brand-light">
<a href="/self-hosting/deployment" className="text-brand-dark dark:text-brand-light">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Unresolved link occurrences detected.

Apart from the change in apps/docs/app/developer-docs/contributing/get-started/components/FAQ.tsx, the old link /docs/self-hosting/deployment is still present in the following files:

  • README.md

Please update these instances to ensure consistency across the documentation.

🔗 Analysis chain

Link updated correctly.

The hyperlink has been updated from /docs/self-hosting/deployment to /self-hosting/deployment, which aligns with the PR objective of fixing broken links in the documentation. This change is consistent with the information provided in the PR summary, which mentions updating the path for the self-hosting documentation link.

To ensure consistency across the documentation, let's verify if this is the only occurrence of this link:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any remaining occurrences of the old link path

# Test: Search for the old link path
rg --type-add 'web:*.{tsx,ts,js,jsx,mdx,md}' --type web '/docs/self-hosting/deployment'

# Test: Search for the new link path to ensure it's used consistently
rg --type-add 'web:*.{tsx,ts,js,jsx,mdx,md}' --type web '/self-hosting/deployment'

Length of output: 1321

Comment on lines +37 to +38
- [Gitpod](/developer-docs/contributing/gitpod)
- [GitHub Codespaces](/developer-docs/contributing/codespaces)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

🔍 Missing Documentation Paths Detected

The updated URL paths for Gitpod and GitHub Codespaces do not exist:

  • developer-docs/contributing/gitpod
  • developer-docs/contributing/codespaces

This may result in broken links within the documentation. Please verify the correct paths or ensure that the corresponding documentation files are present.

🔗 Analysis chain

LGTM! URL paths updated. Please verify functionality.

The URL paths for Gitpod and GitHub Codespaces have been updated by removing the /docs prefix. This change aligns with the PR objective of fixing broken links in the documentation.

To ensure these changes are correct, please run the following script to verify the existence of the new paths:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the updated documentation paths

# Test: Check if the new Gitpod documentation path exists
if fd -t f "gitpod.mdx" | grep -q "developer-docs/contributing/gitpod"; then
    echo "Gitpod documentation path exists"
else
    echo "Error: Gitpod documentation path not found"
fi

# Test: Check if the new GitHub Codespaces documentation path exists
if fd -t f "codespaces.mdx" | grep -q "developer-docs/contributing/codespaces"; then
    echo "GitHub Codespaces documentation path exists"
else
    echo "Error: GitHub Codespaces documentation path not found"
fi

Length of output: 351

@mattinannt mattinannt changed the title fix: broken links in docs fix: sub-navigation sorting in docs Oct 10, 2024
@mattinannt mattinannt merged commit 4c8be95 into main Oct 10, 2024
@mattinannt mattinannt deleted the feature/fix-docs-links branch October 10, 2024 22:17
@coderabbitai coderabbitai bot mentioned this pull request Dec 11, 2024
12 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 14, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant