fix: username overflow issue by jonas-hoebenreich · Pull Request #3501 · formbricks/formbricks

jonas-hoebenreich · 2024-10-11T19:37:30Z

What does this PR do?

Fixes #3500

How should this be tested?

Check survey overview list for short & long usernames

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Formbricks Docs if changes were necessary

Summary by CodeRabbit

Style
- Enhanced styling of the SurveyCard component for improved layout and visual consistency.
- Added max-w-full class to various elements displaying survey details to prevent overflow.

vercel · 2024-10-11T19:37:35Z

@jonas-hoebenreich is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-10-11T19:37:39Z

Walkthrough

The changes in this pull request focus on the SurveyCard component within SurveyCard.tsx. The modifications primarily involve updating the class attributes of several <div> elements to improve their styling properties, specifically by adding the max-w-full class to ensure that survey detail elements do not exceed their container's width. The overall structure and functionality of the component remain unchanged.

Changes

File Path	Change Summary
apps/web/app/(app)/environments/[environmentId]/surveys/components/SurveyCard.tsx	Updated class attributes for styling in multiple `<div>` elements. Added `max-w-full` to improve layout consistency.

Assessment against linked issues

Objective	Addressed	Explanation
Fix username overflow in survey overview (#3500)	✅

Possibly related PRs

fix: Added DialogTitle and DialogDescrtiption components to the dialog. #3146: Updates to dialog components in ShareEmbedSurvey.tsx and ShareSurveyResults.tsx may relate to the styling adjustments in SurveyCard.tsx, as both enhance user interface components within the survey context.

Suggested labels

bug, 🙋🏻‍♂️help wanted

Poem

🐇 In a card where surveys dwell,
Long usernames cast their spell.
With a tweak, the layout's bright,
Overflow's gone, all feels right!
Hopping through code with delight,
A better view, what a sight! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0145589 and 408f03d.

📒 Files selected for processing (1)

apps/web/app/(app)/environments/[environmentId]/surveys/components/SurveyCard.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

apps/web/app/(app)/environments/[environmentId]/surveys/components/SurveyCard.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-10-11T19:37:45Z

Thank you for following the naming conventions for pull request titles! 🙏

DipeshK47 · 2024-10-11T20:56:19Z

/assign

oss-gg · 2024-10-11T20:56:23Z

The /assign command can only be used on issues, not on pull requests.

mattinannt

@jonas-hoebenreich thanks a lot for the fix :-) 🎉

oss-gg · 2024-10-12T05:54:49Z

Awarding jonas-hoebenreich: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/jonas-hoebenreich

fix username overflow issue

408f03d

github-actions bot added bug Something isn't working 🕹️ 150 points 🕹️ oss.gg Community issue via oss.gg labels Oct 11, 2024

mattinannt approved these changes Oct 12, 2024

View reviewed changes

mattinannt added this pull request to the merge queue Oct 12, 2024

Merged via the queue into formbricks:main with commit 807d448 Oct 12, 2024

This was referenced Oct 12, 2024

fix: whitespace in status text should not break to next line #3547

Merged

fix: add a flex wrap to wrap elements if the ui is getting smaller #3576

Closed

SaiSawant1 pushed a commit to SaiSawant1/formbricks that referenced this pull request Oct 14, 2024

fix: username overflow issue (formbricks#3501)

f4b253b

jonas-hoebenreich deleted the username-overflow branch October 15, 2024 12:39

coderabbitai bot mentioned this pull request Oct 23, 2024

fix: survey list spacing and loading #4003

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: username overflow issue#3501

fix: username overflow issue#3501
mattinannt merged 1 commit intoformbricks:mainfrom
jonas-hoebenreich:username-overflow

jonas-hoebenreich commented Oct 11, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Oct 11, 2024

Uh oh!

coderabbitai bot commented Oct 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Oct 11, 2024 •

edited

Loading

Uh oh!

DipeshK47 commented Oct 11, 2024

Uh oh!

oss-gg bot commented Oct 11, 2024

Uh oh!

mattinannt left a comment

Uh oh!

oss-gg bot commented Oct 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jonas-hoebenreich commented Oct 11, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

Uh oh!

vercel bot commented Oct 11, 2024

Uh oh!

coderabbitai bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DipeshK47 commented Oct 11, 2024

Uh oh!

oss-gg bot commented Oct 11, 2024

Uh oh!

mattinannt left a comment

Choose a reason for hiding this comment

Uh oh!

oss-gg bot commented Oct 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonas-hoebenreich commented Oct 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 11, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Oct 11, 2024 •

edited

Loading