apps/web/app/(app)/(onboarding)/organizations/components/OnboardingOptionsContainer.tsx (1)

45-47: Approved: Improved layout responsiveness

The change effectively addresses the layout issue for the onboarding container by introducing conditional classes based on the number of options. This implementation provides a responsive design that adapts well to various screen sizes and option counts.

Consider extracting the class strings into variables for improved readability:

const commonClasses = "flex justify-center gap-8";
const wrapClasses = "w-5/6 flex-wrap lg:w-2/3";

// Then use them in the className prop
className={cn(commonClasses, {
  [wrapClasses]: options.length >= 3,
})}

This approach would make the class application more explicit and easier to maintain.

apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/QuestionsView.tsx (2)

Line range hint 232-252: LGTM: Simplified question update logic.

The removal of backButtonLabel handling and the consistent treatment of buttonLabel, upperLabel, and lowerLabel improve the code's clarity and address the reported issue. This change aligns well with the PR objectives.

Consider extracting the label handling logic into a separate function for better readability:

 const updateQuestion = (questionIdx: number, updatedAttributes: any) => {
   // ... existing code ...

   const attributesToCheck = ["buttonLabel", "upperLabel", "lowerLabel"];

+  const handleEmptyLabels = (question, attributes) => {
+    attributes.forEach((attribute) => {
+      if (Object.keys(updatedAttributes).includes(attribute)) {
+        const currentLabel = question[attribute];
+        if (currentLabel && Object.keys(currentLabel).length === 1 && currentLabel["default"].trim() === "") {
+          delete question[attribute];
+        }
+      }
+    });
+  };

-  attributesToCheck.forEach((attribute) => {
-    if (Object.keys(updatedAttributes).includes(attribute)) {
-      const currentLabel = updatedSurvey.questions[questionIdx][attribute];
-      if (currentLabel && Object.keys(currentLabel).length === 1 && currentLabel["default"].trim() === "") {
-        delete updatedSurvey.questions[questionIdx][attribute];
-      }
-    }
-  });
+  handleEmptyLabels(updatedSurvey.questions[questionIdx], attributesToCheck);

   setLocalSurvey(updatedSurvey);
   validateSurveyQuestion(updatedSurvey.questions[questionIdx]);
 };

This refactoring improves readability and makes the function more maintainable.

---

Issues Found: Incomplete Removal of backButtonLabel

While the backButtonLabel state management has been removed from QuestionsView.tsx, several references to backButtonLabel still exist in other files:

• lib/validation.ts
• components/EditorCardMenu.tsx
• components/QuestionCard.tsx
• components/CTAQuestionForm.tsx

These remaining references may lead to inconsistencies and potential bugs. Please ensure that backButtonLabel is fully removed from all related files to maintain codebase integrity.

🔗 Analysis chain

Line range hint 1-576: LGTM: Removed backButtonLabel state management.

The complete removal of backButtonLabel state management from the component is consistent with the PR objectives and addresses the reported issue. This change simplifies the component's logic and should resolve the problem of back button labels being incorrectly overridden.

To ensure that all references to backButtonLabel have been removed and that this change doesn't introduce any regressions, please run the following verification script:

This script will help verify that all backButtonLabel references have been removed from this file and related files, and check for any TODO comments that might be related to this change.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify complete removal of backButtonLabel and check for any remaining references

# Test 1: Check for any remaining backButtonLabel references in this file
echo "Checking for backButtonLabel references in QuestionsView.tsx:"
rg 'backButtonLabel' apps/web/app/\(app\)/\(survey-editor\)/environments/\[environmentId\]/surveys/\[surveyId\]/edit/components/QuestionsView.tsx

# Test 2: Check for backButtonLabel references in other files that might be affected
echo "Checking for backButtonLabel references in other related files:"
rg 'backButtonLabel' apps/web/app/\(app\)/\(survey-editor\)/environments/\[environmentId\]/surveys/\[surveyId\]/edit/

# Test 3: Check for any TODO comments related to this change
echo "Checking for related TODO comments:"
rg 'TODO.*back.*button' apps/web/app/\(app\)/\(survey-editor\)/environments/\[environmentId\]/surveys/\[surveyId\]/edit/

echo "Verification complete. Please review the results to ensure all backButtonLabel references have been properly removed."

Length of output: 3623

apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/QuestionCard.tsx (1)

474-481: Correct implementation of "Back" button label updates with minor improvement suggestion

The usage of updateEmptyButtonLabels for the "Back" button is well-implemented:

1. It correctly uses "backButtonLabel" as the labelKey.
2. The skipIndex is set to 0, preventing unnecessary updates to the first question's label.
3. The translatedBackButtonLabel is properly constructed with the current language code.

This implementation ensures consistent "Back" button labels across the survey while respecting the first question's unique requirements.

For consistency with the "Next" button implementation, consider adding a check for the existence of question.backButtonLabel before updating:

 onBlur={(e) => {
   if (!question.backButtonLabel) return;
   let translatedBackButtonLabel = {
     ...question.backButtonLabel,
     [selectedLanguageCode]: e.target.value,
   };
+  if (questionIdx === 0) return;
   updateEmptyButtonLabels("backButtonLabel", translatedBackButtonLabel, 0);
 }}

This change ensures that the first question's back button label isn't unnecessarily updated, mirroring the logic used for the last question's next button.

Configuration used: CodeRabbit UI
Review profile: CHILL