feat: add radio button as an input type#445
Conversation
surajshetty3416
left a comment
surajshetty3416
left a comment
There was a problem hiding this comment.
@mrswastik-robot Maybe create a new section called "Input Options" and move all related properties under that? Currently, it'll be hard to discover those properties under "Accessibility".
Also, keep label of the property smaller so that it does not take two lines.
|
Hi @surajshetty3416, should I create a new file containing all the input-related properties and only display them when an input element is selected? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #445 +/- ##
========================================
Coverage 49.26% 49.26%
========================================
Files 28 28
Lines 2182 2182
========================================
Hits 1075 1075
Misses 1107 1107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @surajshetty3416 , I have made the requested changes, this is what it looks like now: 
|
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
tries to fix #348
This PR adds the radio as an option for the inputs, and introduces Radio-specific properties like
RadioGroupName,RadioValue, andInitiallyChecked. I have tried the changes locally and they work flawlessly. Happy to make any requested changes :)Credit goes to @ShreyasTheNewbie for trying it first, so it wasn't much of a work for me!