Skip to content

fix(Code Editor): tab behaviour on multiline selection#446

Merged
surajshetty3416 merged 1 commit intofrappe:developfrom
ruchamahabal:fix-tab-behaviour
Dec 18, 2025
Merged

fix(Code Editor): tab behaviour on multiline selection#446
surajshetty3416 merged 1 commit intofrappe:developfrom
ruchamahabal:fix-tab-behaviour

Conversation

@ruchamahabal
Copy link
Member

Before:

Selecting multiple lines and pressing tab deletes the block

tab-before.mp4

After:

Use codemirror's indentMore, indentLess commands to indent on tab, and deindent on shift + tab

tab-after.mp4

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.26%. Comparing base (91bf502) to head (8a27ea4).
⚠️ Report is 116 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #446   +/-   ##
========================================
  Coverage    49.26%   49.26%           
========================================
  Files           28       28           
  Lines         2182     2182           
========================================
  Hits          1075     1075           
  Misses        1107     1107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NagariaHussain
Copy link
Contributor

Code Editor component should be moved to Frappe UI? 👀

@surajshetty3416 surajshetty3416 merged commit 34e0ae2 into frappe:develop Dec 18, 2025
6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants