refactor: Fix editor layout stacking#448
Merged
surajshetty3416 merged 23 commits intodevelopfrom Dec 21, 2025
Merged
Conversation
Make changes to make codebase compatible with latest frappe-ui
- Re-organise Dialog to keep it at the top - Minor style fixes
…iles - And fix the stacking order of elements to avoid unexpected element overlap over dialogs - remove unused AppsMenu component
- to fix stacking order and avoid unexpected overlap over dialogs
- Fix the stacking order by re-organizing elments instead of using z-index
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #448 +/- ##
========================================
Coverage 49.26% 49.26%
========================================
Files 28 28
Lines 2182 2182
========================================
Hits 1075 1075
Misses 1107 1107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
surajshetty3416
force-pushed
the
update-frappe-ui-2
branch
from
1334e84 to
7080388
Compare
- Cleanup AppsMenu component registration from components.d.ts - Add BlockOptions support to blockData prop to improve the flexibility - Add type annotations wherever it was missing - Add fallback values in autocomplete - Fix incorrect type import in blockController.ts
surajshetty3416
force-pushed
the
update-frappe-ui-2
branch
from
b1a65be to
992f9af
Compare
- Fix dark mode of autocomplete to make it look consistent with other inputs - Fix type for placement in ColorInput. It should only accept specific options - Remove unnecessary class overrides in Input.vue
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
frappe-uifrom v0.1.154 to v0.1.242 to get the enhanced bundling in frappe-ui and to get smaller bundle sizes ⚡Before:
After:
--
Since this was a huge jump in update (although patch versions) 👀, there were quite a few breaking changes
The primary one being the dialog not having its own z-index anymore, which means it has to be brought to the top by rearranging the layout. Had to do quite a few refactors that involved removing almost all z-index I used to stack layouts and rearrange them so that they are automatically stacked as required following the normal document flow.
Another breaking change involved removing all the absolute imports, as they are not supported anymore after this change. Also, had to push this fix to make it work properly.
Also, simplified a couple of complex components like
PageDashboardandTextBlockby splitting them into more logical subcomponents.