feat: Add support for dark mode images and refactor PropertyControl#464
Merged
surajshetty3416 merged 11 commits intodevelopfrom Jan 27, 2026
Merged
feat: Add support for dark mode images and refactor PropertyControl#464surajshetty3416 merged 11 commits intodevelopfrom
surajshetty3416 merged 11 commits intodevelopfrom
Conversation
- Added support for variant. Using this we can upload dark mode of an image - Split PropertyControl into BasePropertyControl, StylePropertyControl, AttributePropertyControl for focused usage - Replace usages of PropertyControl with appropriate new controls
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #464 +/- ##
===========================================
- Coverage 52.90% 52.56% -0.35%
===========================================
Files 28 28
Lines 2202 2222 +20
===========================================
+ Hits 1165 1168 +3
- Misses 1037 1054 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove unnecessary props from BasePropertyControl
- so that img tag does not treat picture as parent
- to avoid force rerender each time isDark is initiated inside block
surajshetty3416
force-pushed
the
option-to-set-dark-mode-image
branch
from
250c80c to
9edb31b
Compare
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
surajshetty3416
added a commit
that referenced
this pull request
Feb 7, 2026
After #464, property controls stopped accepting values as boolean and number and used to auto convert all values to string, which is why components like TabButton stopped working as expected.
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2026
After #464, property controls stopped accepting values as boolean and number and used to auto convert all values to string, which is why components like TabButton stopped working as expected. (cherry picked from commit 37a92c2) # Conflicts: # frontend/src/components/Controls/BasePropertyControl.vue # frontend/src/components/Controls/PropertyControlInput.vue # frontend/src/components/Controls/TabButtons.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-01-27.at.4.12.33.PM.mov
AttributePropertyControl(for HTML attributes),StylePropertyControl(for style properties) andBasePropertyControl(for general purpose)BasePropertyControlnow has "variants" option using which a control can be extendedStylePropertyControlinternally uses variants to show state style options in the dropdownsrcpropertyControl uses variant to show "Dark Mode" option