Skip to content

ci: update for Go 1.8#162

Merged
nathany merged 1 commit intomasterfrom
go17
Mar 2, 2017
Merged

ci: update for Go 1.8#162
nathany merged 1 commit intomasterfrom
go17

Conversation

@nathany
Copy link
Contributor

@nathany nathany commented Aug 16, 2016

two most recent stable versions + tip

@nathany
Copy link
Contributor Author

nathany commented Aug 16, 2016

it looks like there is a data race to fix

@bep
Copy link
Member

bep commented Aug 16, 2016

it looks like there is a data race to fix

#150

@nathany
Copy link
Contributor Author

nathany commented Oct 5, 2016

Still seeing data races on Travis. Doh!

Specifically on macOS. The race on Linux is resolved.

@pattyshack
Copy link

the data race is in the bsd build; that uses kqueue instead of inotify. #177 will not help here

@nathany
Copy link
Contributor Author

nathany commented Oct 5, 2016

data races in all the places

will come back to that one. 💤

@nathany
Copy link
Contributor Author

nathany commented Oct 5, 2016

on macOS Sierra 10.12

❯ go test -race -test.count=10
PASS
ok      github.com/fsnotify/fsnotify    104.165s

fsnotify git/master  
❯ go16 test -race -test.count=10

... the later doesn't seem to be finishing anytime soon

❯ go16 test -race 
# testmain
fatal error: unexpected signal during runtime execution
...

But then Go 1.6 doesn't work on Sierra anyway. I wonder what version of macOS Travis is running? Might need a macOS VM just to test Go 1.6 locally. 😢

@nathany nathany changed the title travis: update for Go 1.7 travis: update for Go 1.8 Feb 18, 2017
@nathany
Copy link
Contributor Author

nathany commented Feb 18, 2017

well this is embarrassing... 😊

updated for Go 1.8

@nathany
Copy link
Contributor Author

nathany commented Feb 18, 2017

also requested Go 1.8 for AppVeyor. appveyor/ci#1330

Currently Windows tests are using Go 1.7.1

@nathany nathany changed the title travis: update for Go 1.8 ci: update for Go 1.8 Feb 18, 2017
@twpayne
Copy link
Contributor

twpayne commented Mar 1, 2017

FWIW you can use 1.x to get the latest stable release of Go, and (for example) 1.7.x to get the latest version of 1.7. For example:

go:
  - 1.7.x
  - 1.x
  - tip

@nathany
Copy link
Contributor Author

nathany commented Mar 1, 2017

@twpayne Thanks for the note. The only problem with using .x is we need to wait for Travis CI to update their aliases, but they are in place now. I will update.

See: travis-ci/travis-build#956

two most recent stable versions + tip
@nathany nathany merged commit 7d7316e into master Mar 2, 2017
@nathany nathany deleted the go17 branch March 2, 2017 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants