Conversation
Using:
if event.Op&fsnotify.Create == fsnotify.Create {
}
is overly verbose and awkward; a Has() method makes this much nicer:
if event.Has(fsnotify.Create) {
}
PR #76 was previously rejected; I think that HasCreate() etc. is
overkill, but a Has() method makes the library quite a bit more
convenient IMO.
I added it to both the Event and Op to avoid confusion; with this we can
change the Op field to be private in a future v2.
Fixes #107
nathany
approved these changes
Jul 30, 2022
|
What version does the method |
Member
Author
|
It's not yet in any released version. |
This was referenced Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using:
is overly verbose and awkward; a Has() method makes this much nicer:
PR #76 was previously rejected; I think that HasCreate() etc. is
overkill, but a Has() method makes the library quite a bit more
convenient IMO.
I added it to both the Event and Op to avoid confusion; with this we can
change the Op field to be private in a future v2.
Fixes #107