add missing pipe-character for images in meta step#595
Merged
gaul merged 1 commit intogaul:masterfrom Jan 11, 2024
Merged
Conversation
new-lines without pipe don't get treated as newlines, see https://yaml-multiline.info/
Owner
|
Thanks for your continued investigation of this. |
Owner
|
This appears to be correctly pushing again: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @gaul.
As promised I had another look and I missed the pipe character in the images-definition which leads to ignored newlines which then produce the wrong outputs in the meta step.
(I tested locally in a private repo and copied my changes to the fork afterwards, i must have missed this one)
Wrong version from the failed action log including "name" from line 35 before
,enable=true:How it should look
The automatic build triggered through this PR looks correct this time, feel free to mention me if it doesn't.
Not quite sure yet, but chances are high I will try to fix those warnings too - they bother me somehow. :)