Merged
Conversation
Member
|
should we update the libraries that throw so many E_DEPRECATED warnings? maybe only for php 7.4 in travis.. what do you think? |
Contributor
Author
|
I believe it is not a blocker (only deprecations) but it would be great to upgrade. Two dependencies are at fault: PHPUnit and PHP Code Sniffer. PHPUnit starts spitting deprecated issues with 7.2 and PHP Code Sniffer with 7.4. I guess it is worth giving it a try with the latest versions of both dependencies in 7.4 and see how it reacts, not sure if the source will have to be edited to do so though. What do you think of doing this in a follow up PR to unblock this one? |
Member
|
thx for your contribution. I've created a dedicated issue #163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.