Merged
Conversation
tonyo
suggested changes
Aug 20, 2020
Contributor
tonyo
left a comment
tonyo
left a comment
There was a problem hiding this comment.
Nice!
Minor suggestions.
And CHANGELOG, please.
Co-authored-by: Anton Ovchinnikov <[email protected]>
tonyo
approved these changes
Aug 20, 2020
BYK
added a commit
that referenced
this pull request
Mar 11, 2026
- simple-git: 3.30.0 → 3.33.0 (fixes CVE-2026-28292, CRITICAL CVSS 9.8) RCE via case-insensitive protocol.allow bypass in blockUnsafeOperationsPlugin - tar: 7.5.10 → 7.5.11 (fixes CVE-2026-29786, HIGH CVSS 8.2) Hardlink path traversal via drive-relative linkpath Also dismissed Dependabot alert #119 (@tootallnate/once, LOW severity) as tolerable risk — blocked upstream by teeny-request pinning http-proxy-agent@^5, and the vulnerability requires AbortSignal usage patterns not present in Craft.
BYK
added a commit
that referenced
this pull request
Mar 11, 2026
) ## Security Dependency Updates Addresses open Dependabot alerts by updating vulnerable direct dependencies: - **simple-git**: 3.30.0 → 3.33.0 — fixes [CVE-2026-28292](GHSA-r275-fr43-pm7q) (CRITICAL, CVSS 9.8). RCE via case-insensitive `protocol.allow` bypass in `blockUnsafeOperationsPlugin`. - **tar**: 7.5.10 → 7.5.11 — fixes [CVE-2026-29786](GHSA-qffp-2rhf-9h96) (HIGH, CVSS 8.2). Hardlink path traversal via drive-relative linkpath. ### Dismissed alert [Alert #119](https://github.com/getsentry/craft/security/dependabot/119) (`@tootallnate/once`, LOW severity) was dismissed as tolerable risk. The fix requires a major version bump (v2 → v3) but is blocked upstream: `teeny-request` pins `http-proxy-agent@^5` which hard-requires `@tootallnate/once@2`. The vulnerability requires AbortSignal usage patterns not present in Craft, and `@google-cloud/storage` is a devDependency only. ### Verification - ✅ Build passes - ✅ All tests pass (6 pre-existing e2e failures due to missing EDITOR env var — unrelated)
BYK
added a commit
that referenced
this pull request
Mar 16, 2026
- simple-git: 3.30.0 → 3.33.0 (fixes CVE-2026-28292, CRITICAL CVSS 9.8) RCE via case-insensitive protocol.allow bypass in blockUnsafeOperationsPlugin - tar: 7.5.8 → 7.5.11 (fixes CVE-2026-29786, HIGH CVSS 8.2) Hardlink path traversal via drive-relative linkpath Also dismissed Dependabot alert #119 (@tootallnate/once, LOW severity) as tolerable risk — blocked upstream by teeny-request pinning http-proxy-agent@^5, and the vulnerability requires AbortSignal usage patterns not present in Craft.
BYK
added a commit
that referenced
this pull request
Mar 16, 2026
- simple-git: 3.30.0 → 3.33.0 (fixes CVE-2026-28292, CRITICAL CVSS 9.8) RCE via case-insensitive protocol.allow bypass in blockUnsafeOperationsPlugin - tar: 7.5.8 → 7.5.11 (fixes CVE-2026-29786, HIGH CVSS 8.2) Hardlink path traversal via drive-relative linkpath Also dismissed Dependabot alert #119 (@tootallnate/once, LOW severity) as tolerable risk — blocked upstream by teeny-request pinning http-proxy-agent@^5, and the vulnerability requires AbortSignal usage patterns not present in Craft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I successfully did released https://github.com/getsentry/raven-ruby/releases/tag/3.0.2 with this branch.