fix(docker): Disable HTML escaping in image names by default#127
Merged
Conversation
We used Mustache templates that were already available for image name formatting. Musache escapes all HTML-unsafe characters by default which rightly confused the Docker CLI client. This patch uses the `{{{varName}}}` pattern for the default format config to disable escaping.
Member
Author
|
(pun intended) |
HazAT
approved these changes
Oct 8, 2020
jan-auer
approved these changes
Oct 8, 2020
Member
jan-auer
left a comment
jan-auer
left a comment
There was a problem hiding this comment.
Sorry for the sloppy reviews :)
Member
Author
This is what happens when you don't have tests and nobody calls you out for them ;) |
BYK
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 15, 2020
Depends on getsentry/craft#125, getsentry/craft#126, getsentry/craft#127, getsentry/craft#128 and all of these being published as `[email protected]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used Mustache templates that were already available for image name formatting. Musache escapes all HTML-unsafe characters by default which rightly confused the Docker CLI client. This patch uses the
{{{varName}}}pattern for the default format config to disable escaping.