Closed
Conversation
| name = "pypi" | ||
|
|
||
| [packages] | ||
| "e1839a8" = {editable = true, path = ".", extras = ["optional", "dev", "tests"]} |
Contributor
There was a problem hiding this comment.
Isn't this problematic?
Member
There was a problem hiding this comment.
pypa/pipfile#93 (comment) Can we change the name to just 'sentry'?
Member
Author
|
closing; see discussion on python-poetry/poetry#794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first generated a lockfile from an up-to-date dev environment with
pipenv lock. Because thePipfileonly has sentry as an editable install requirement with all the extras, the lockfile can always be kept up to date without manualPipfileediting orpipenv installcalls - simply invokepipenv lockafter editing our requirements files which will get picked up bysetuptoolsusing oursetup.py.Basically, this PR adds a pipenv lockfile without really impacting our current workflow.
So the virtualenvs are nearly identical:
I don't really know why pipenv installed atomicwrites. It isn't a subdependency of anything, and so can be removed from the lockfile.