ref(uploads): Split build_artifact_bundle into separate module#2922
Merged
szokeasaurusrex merged 1 commit intomasterfrom Nov 10, 2025
Merged
ref(uploads): Split build_artifact_bundle into separate module#2922szokeasaurusrex merged 1 commit intomasterfrom
build_artifact_bundle into separate module#2922szokeasaurusrex merged 1 commit intomasterfrom
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Move `build_artifact_bundle` (and functions only it calls) out of `crate::utils::file_upload` and into a new module called `crate::utils::source_bundle`, also renaming the function to `build`. We are also moving terminology to "source bundle," as these are **not** the artifact bundles for JavaScript and should not be confused with them. This change only moves code around and renames items; there are no other code changes. Those come in subsequent PRs.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/artifact-bundle
branch
from
3909c7b to
d4a542a
Compare
This was referenced Nov 7, 2025
![sentry[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
|
The description says the new module is called |
loewenheim
approved these changes
Nov 10, 2025
Member
Author
Thanks! Yeah, it should say "source bundle" everywhere. In an earlier iteration of this PR, I called the module "artifact bundle" but that was confusing, since these are not the artifact bundles used for uploading sourcemaps, but something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
build_artifact_bundle(and functions only it calls) out ofcrate::utils::file_uploadand into a new module calledcrate::utils::source_bundle, also renaming the function tobuild.This change only moves code around; it is done in preparation for the next PR.
Issues
/chunk-uploadforbundle-jvm#2927