Skip to content

[v9] Encourage using inheritOrSampleWith for tracesSampler in js#12544

Merged
lforst merged 3 commits intomasterfrom
lforst-parentsamplerate
Feb 10, 2025
Merged

[v9] Encourage using inheritOrSampleWith for tracesSampler in js#12544
lforst merged 3 commits intomasterfrom
lforst-parentsamplerate

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Feb 3, 2025 •
edited
Loading

DESCRIBE YOUR PR

Swaps over to documenting inheritOrSampleWith over parentSampled as migration guide for v9. Wasn't done with a versioned docs page because it was too annoying.

Resolves getsentry/sentry-javascript#15124

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

@vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 5:42pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 5:42pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 5:42pm

@lforst lforst requested a review from mydea February 3, 2025 12:46
@codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.7MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.38MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/dH05EoQJk5oA1gI63t21s/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/dH05EoQJk5oA1gI63t21s/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Ouo51kQm1b-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/Ouo51kQm1b-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.63MB -0.0%
../instrumentation.js -3 bytes 965.23kB -0.0%
9523.js -3 bytes 941.45kB -0.0%

@mydea
Copy link
Member

mydea commented Feb 3, 2025

Not directly related, but when we update this again, let's make sure to remove this line on this page too:

If a sampling decision is passed to startTransaction, that decision will be used, overriding everything else.

@lforst lforst mentioned this pull request Feb 3, 2025
Merged
@lforst
Copy link
Contributor Author

lforst commented Feb 3, 2025

Not directly related, but when we update this again, let's make sure to remove this line on this page too:

If a sampling decision is passed to startTransaction, that decision will be used, overriding everything else.

I think we can update this already now

@lforst lforst changed the title Encourage using parentSampleRate for tracesSampler in js Encourage using inheritOrSampleWith for tracesSampler in js Feb 3, 2025
coolguyzone
coolguyzone approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lforst lforst changed the title Encourage using inheritOrSampleWith for tracesSampler in js [js/v9] Encourage using inheritOrSampleWith for tracesSampler in js Feb 4, 2025
@lforst lforst changed the title [js/v9] Encourage using inheritOrSampleWith for tracesSampler in js [v9] Encourage using inheritOrSampleWith for tracesSampler in js Feb 6, 2025
@lforst lforst merged commit 0b49bc7 into master Feb 10, 2025
11 checks passed
@lforst lforst deleted the lforst-parentsamplerate branch February 10, 2025 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@coolguyzone coolguyzone coolguyzone approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v9] Document how to properly use tracesSampler with incoming parentSampleRate

3 participants

@lforst @mydea @coolguyzone